Enable unneeded_throws_rethrows rule (#6335)

Author: SimplyDanny

.swiftlint.yml

@@ -46,7 +46,6 @@ disabled_rules:
   - todo
   - trailing_closure
   - type_contents_order
-  - unneeded_throws_rethrows
   - vertical_whitespace_between_cases
 
 # Configurations

Plugins/SwiftLintCommandPlugin/CommandContext.swift

@@ -79,7 +79,7 @@ extension XcodePluginContext: CommandContext {
         "target"
     }
 
-    func targets(named names: [String]) throws -> [(paths: [String], name: String)] {
+    func targets(named names: [String]) -> [(paths: [String], name: String)] {
         if names.isEmpty {
             return [(paths: [xcodeProject.directory.string], name: xcodeProject.displayName)]
         }

Source/SwiftLintBuiltInRules/Rules/RuleConfigurations/MultilineParametersConfiguration.swift

@@ -11,6 +11,7 @@ struct MultilineParametersConfiguration: SeverityBasedRuleConfiguration {
     @ConfigurationElement(key: "max_number_of_single_line_parameters")
     private(set) var maxNumberOfSingleLineParameters: Int?
 
+    // swiftlint:disable:next unneeded_throws_rethrows
     func validate() throws(Issue) {
         guard let maxNumberOfSingleLineParameters else {
             return

Source/SwiftLintCore/Protocols/RuleConfiguration.swift

@@ -35,6 +35,7 @@ public extension SeverityBasedRuleConfiguration {
 public extension RuleConfiguration {
     var parameterDescription: RuleConfigurationDescription? { nil }
 
+    // swiftlint:disable:next unneeded_throws_rethrows
     func validate() throws(Issue) {
         // Do nothing by default.
     }

Source/SwiftLintCoreMacros/TemporaryDirectory.swift

@@ -9,11 +9,9 @@ private let pathPrefix = ""
 #endif
 
 enum TemporaryDirectory: BodyMacro {
-    static func expansion(
-        of _: AttributeSyntax,
-        providingBodyFor declaration: some DeclSyntaxProtocol & WithOptionalCodeBlockSyntax,
-        in context: some MacroExpansionContext
-    ) throws -> [CodeBlockItemSyntax] {
+    static func expansion(of _: AttributeSyntax,
+                          providingBodyFor declaration: some DeclSyntaxProtocol & WithOptionalCodeBlockSyntax,
+                          in context: some MacroExpansionContext) -> [CodeBlockItemSyntax] {
         guard let body = declaration.body else {
             context.diagnose(SwiftLintCoreMacroError.noBody.diagnose(at: declaration))
             return []

Source/SwiftLintCoreMacros/WorkingDirectory.swift

@@ -3,11 +3,9 @@ import SwiftSyntaxBuilder
 import SwiftSyntaxMacros
 
 enum WorkingDirectory: BodyMacro {
-    static func expansion(
-        of attributes: AttributeSyntax,
-        providingBodyFor declaration: some DeclSyntaxProtocol & WithOptionalCodeBlockSyntax,
-        in context: some MacroExpansionContext
-    ) throws -> [CodeBlockItemSyntax] {
+    static func expansion(of attributes: AttributeSyntax,
+                          providingBodyFor declaration: some DeclSyntaxProtocol & WithOptionalCodeBlockSyntax,
+                          in context: some MacroExpansionContext) -> [CodeBlockItemSyntax] {
         guard let body = declaration.body else {
             context.diagnose(SwiftLintCoreMacroError.noBody.diagnose(at: declaration))
             return []

Source/swiftlint/Commands/Baseline.swift

@@ -38,7 +38,7 @@ extension SwiftLint {
 
         func run() throws {
             let savedBaseline = try SwiftLintCore.Baseline(fromPath: options.baseline)
-            try report(savedBaseline.violations, using: reportingOptions.reporter, to: reportingOptions.output)
+            report(savedBaseline.violations, using: reportingOptions.reporter, to: reportingOptions.output)
         }
     }
 
@@ -63,12 +63,12 @@ extension SwiftLint {
         func run() throws {
             let baseline = try SwiftLintCore.Baseline(fromPath: options.baseline)
             let otherBaseline = try SwiftLintCore.Baseline(fromPath: otherBaseline)
-            try report(baseline.compare(otherBaseline), using: reportingOptions.reporter, to: reportingOptions.output)
+            report(baseline.compare(otherBaseline), using: reportingOptions.reporter, to: reportingOptions.output)
         }
     }
 }
 
-private func report(_ violations: [StyleViolation], using reporterIdentifier: String?, to output: String?) throws {
+private func report(_ violations: [StyleViolation], using reporterIdentifier: String?, to output: String?) {
     let reporter = reporterFrom(identifier: reporterIdentifier)
     let report = reporter.generateReport(violations)
     if report.isNotEmpty {

Source/swiftlint/Commands/Docs.swift

@@ -11,7 +11,7 @@ extension SwiftLint {
         @Argument(help: "The identifier of the rule to open the documentation for")
         var ruleID: String?
 
-        func run() throws {
+        func run() {
             var subPage = ""
             if let ruleID {
                 if RuleRegistry.shared.rule(forID: ruleID) == nil {

Source/swiftlint/Commands/Reporters.swift

@@ -6,7 +6,7 @@ extension SwiftLint {
     struct Reporters: ParsableCommand {
         static let configuration = CommandConfiguration(abstract: "Display the list of reporters and their identifiers")
 
-        func run() throws {
+        func run() {
             print(TextTable(reporters: reportersList).render())
         }
     }

Tests/BuiltInRulesTests/ExpiringTodoRuleTests.swift

@@ -123,7 +123,7 @@ final class ExpiringTodoRuleTests: SwiftLintTestCase {
         XCTAssertEqual(violations[0].location.line, 2)
     }
 
-    func testBadExpiryTodoFormat() throws {
+    func testBadExpiryTodoFormat() {
         let ruleConfig = ExpiringTodoConfiguration(
             dateFormat: "dd/yyyy/MM"
         )