Track variables declared in tuples (#6565)

Author: SimplyDanny

CHANGELOG.md

@@ -68,6 +68,11 @@
   [SimplyDanny](https://github.com/SimplyDanny)
   [#6466](https://github.com/realm/SwiftLint/issues/6466)
 
+* Track identifiers declared in tuples to avoid false positives in the
+  `redundant_self` rule.  
+  [SimplyDanny](https://github.com/SimplyDanny)
+  [#6553](https://github.com/realm/SwiftLint/issues/6553)
+
 ## 0.63.2: High-Speed Extraction
 
 ### Breaking

Source/SwiftLintBuiltInRules/Rules/Style/RedundantSelfRuleExamples.swift

@@ -117,6 +117,16 @@ struct RedundantSelfRuleExamples {
                 }
             }
             """),
+        Example("""
+            struct S {
+                var x = 0, y = 0
+                init() {
+                    let (x, y) = (1, 2)
+                    self.x = x
+                    self.y = y
+                }
+            }
+            """, configuration: ["only_in_closures": false]),
     ]
 
     static let triggeringExamples = [

Source/SwiftLintCore/Visitors/DeclaredIdentifiersTrackingVisitor.swift

@@ -205,6 +205,10 @@ open class DeclaredIdentifiersTrackingVisitor<Configuration: RuleConfiguration>:
     private func collectIdentifiers(from pattern: PatternSyntax) {
         if let id = pattern.as(IdentifierPatternSyntax.self)?.identifier {
             scope.addToCurrentScope(.localVariable(name: id))
+        } else if let tuple = pattern.as(TuplePatternSyntax.self) {
+            for element in tuple.elements {
+                collectIdentifiers(from: element.pattern)
+            }
         }
     }
 }