Skip to content

Fix serialize manifest tests #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JayPanoz merged 6 commits into from
Jan 23, 2026
Merged

Fix serialize manifest tests #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ad8125a
fix: correct BCP-47 tag for an undefined language
SifAa Nov 25, 2025
5e33e6a
fix: correct serialization of sortAs to its RWPM JSON representation
SifAa Nov 25, 2025
c1e4b85
review follow up
SifAa Jan 23, 2026
919422e
Fix tests
JayPanoz Jan 23, 2026
e5daf9a
Merge branch 'develop' into fix-serialize-manifest-tests
JayPanoz Jan 23, 2026
07159e5
Fix sortAs tests
JayPanoz Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions shared/test/Contributor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ describe('Contributor Tests', () => {
name: new LocalizedString('Colin Greenwood'),
}).serialize()
).toEqual({
name: { undefined: 'Colin Greenwood' },
name: { und: 'Colin Greenwood' },
});
});

Expand All @@ -187,8 +187,8 @@ describe('Contributor Tests', () => {
]),
}).serialize()
).toEqual({
name: { undefined: 'Colin Greenwood' },
sortAs: { undefined: 'greenwood' },
name: { und: 'Colin Greenwood' },
sortAs: { und: 'greenwood' },
identifier: 'colin',
altIdentifier: [{ scheme: 'http://example.com/author-id', value: 'author-22222' }],
role: ['bassist'],
Expand All @@ -211,7 +211,7 @@ describe('Contributor Tests', () => {
]).serialize()
).toEqual([
{
name: { undefined: 'Thom Yorke' },
name: { und: 'Thom Yorke' },
},
{
name: { en: 'Jonny Greenwood', fr: 'Jean Boisvert' },
Expand Down
8 changes: 4 additions & 4 deletions shared/test/LocalizedString.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ describe('LocalizedString Tests', () => {

it('get JSON with one translation and no language', () => {
expect(new LocalizedString('a string').serialize()).toEqual({
undefined: 'a string',
und: 'a string',
});
});

Expand All @@ -42,12 +42,12 @@ describe('LocalizedString Tests', () => {
new LocalizedString({
en: 'a string',
fr: 'une chaîne',
undefined: 'bir metin',
und: 'bir metin',
}).serialize()
).toEqual({
en: 'a string',
fr: 'une chaîne',
undefined: 'bir metin',
und: 'bir metin',
});
});

Expand All @@ -74,7 +74,7 @@ describe('LocalizedString Tests', () => {
new LocalizedString({
foo: 'a string',
bar: 'une chaîne',
undefined: 'Surgh',
und: 'Surgh',
}).getTranslation()
).toEqual('Surgh');
});
Expand Down
4 changes: 2 additions & 2 deletions shared/test/Manifest.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ describe('Manifest Tests', () => {
readingOrder: new Links([]),
}).serialize()
).toEqual({
metadata: { title: { undefined: 'Title' } },
metadata: { title: { und: 'Title' } },
links: [],
readingOrder: [],
});
Expand Down Expand Up @@ -177,7 +177,7 @@ describe('Manifest Tests', () => {
}).serialize()
).toEqual({
'@context': ['https://readium.org/webpub-manifest/context.jsonld'],
metadata: { title: { undefined: 'Title' } },
metadata: { title: { und: 'Title' } },
links: [{ href: '/manifest.json', rel: ['self'] }],
readingOrder: [{ href: '/chap1.html', type: 'text/html' }],
resources: [{ href: '/image.png', type: 'image/png' }],
Expand Down
40 changes: 20 additions & 20 deletions shared/test/Metadata.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ describe('Metadata Tests', () => {
title: new LocalizedString('Title'),
}).serialize()
).toEqual({
title: { undefined: 'Title' },
title: { und: 'Title' },
});
});

Expand Down Expand Up @@ -393,31 +393,31 @@ describe('Metadata Tests', () => {
language: ['en', 'fr'],
sortAs: { en: 'sort key', fr: 'clé de tri' },
subject: [
{ name: { undefined: 'Science Fiction' } },
{ name: { undefined: 'Fantasy' } },
{ name: { und: 'Science Fiction' } },
{ name: { und: 'Fantasy' } },
],
author: [{ name: { undefined: 'Author' } }],
translator: [{ name: { undefined: 'Translator' } }],
editor: [{ name: { undefined: 'Editor' } }],
artist: [{ name: { undefined: 'Artist' } }],
illustrator: [{ name: { undefined: 'Illustrator' } }],
letterer: [{ name: { undefined: 'Letterer' } }],
penciler: [{ name: { undefined: 'Penciler' } }],
colorist: [{ name: { undefined: 'Colorist' } }],
inker: [{ name: { undefined: 'Inker' } }],
narrator: [{ name: { undefined: 'Narrator' } }],
contributor: [{ name: { undefined: 'Contributor' } }],
publisher: [{ name: { undefined: 'Publisher' } }],
imprint: [{ name: { undefined: 'Imprint' } }],
author: [{ name: { und: 'Author' } }],
translator: [{ name: { und: 'Translator' } }],
editor: [{ name: { und: 'Editor' } }],
artist: [{ name: { und: 'Artist' } }],
illustrator: [{ name: { und: 'Illustrator' } }],
letterer: [{ name: { und: 'Letterer' } }],
penciler: [{ name: { und: 'Penciler' } }],
colorist: [{ name: { und: 'Colorist' } }],
inker: [{ name: { und: 'Inker' } }],
narrator: [{ name: { und: 'Narrator' } }],
contributor: [{ name: { und: 'Contributor' } }],
publisher: [{ name: { und: 'Publisher' } }],
imprint: [{ name: { und: 'Imprint' } }],
layout: 'fixed',
readingProgression: 'rtl',
description: 'Description',
duration: 4.24,
numberOfPages: 240,
belongsTo: {
collection: [{ name: { undefined: 'Collection' } }],
series: [{ name: { undefined: 'Series' } }],
'schema:Periodical': [{ name: { undefined: 'Periodical' } }],
collection: [{ name: { und: 'Collection' } }],
series: [{ name: { und: 'Series' } }],
'schema:Periodical': [{ name: { und: 'Periodical' } }],
},
tdm: {
reservation: 'all',
Expand Down Expand Up @@ -451,7 +451,7 @@ describe('Metadata Tests', () => {
title: new LocalizedString('Title'),
}).serialize()
).toEqual({
title: { undefined: 'Title' }
title: { und: 'Title' }
});
});

Expand Down
10 changes: 5 additions & 5 deletions shared/test/Subject.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ describe('Subject Tests', () => {
name: new LocalizedString('Science Fiction'),
}).serialize()
).toEqual({
name: { undefined: 'Science Fiction' },
name: { und: 'Science Fiction' },
});
});

Expand All @@ -141,8 +141,8 @@ describe('Subject Tests', () => {
]),
}).serialize()
).toEqual({
name: { undefined: 'Science Fiction' },
sortAs: { undefined: 'science-fiction' },
name: { und: 'Science Fiction' },
sortAs: { und: 'science-fiction' },
scheme: 'http://scheme',
code: 'CODE',
links: [{ href: 'pub1' }, { href: 'pub2' }],
Expand All @@ -160,10 +160,10 @@ describe('Subject Tests', () => {
]).serialize()
).toEqual([
{
name: { undefined: 'Fantasy' },
name: { und: 'Fantasy' },
},
{
name: { undefined: 'Science Fiction' },
name: { und: 'Science Fiction' },
scheme: 'http://scheme',
},
]);
Expand Down