No description in MHD benchmark

[martymichal]

Maybe the benchmark is self-descriptive but not to me :).

[linhsolar]

@rantahar @minhtribk12 current restructure all benchmarks so maybe you guys put some hints in

[nguu0123]

I added a short description in https://github.com/rdsea/odop/blob/main/benchmark/MHD/README.md . Ping me on Teams or reply here if you find something unclear/missing

[martymichal]

Thanks for adding the description. It is still not clear to me how to use the benchmark. Is benchmark/MHD a part of examples/MHD? Or are those two separate? As it currently is, I don't know how I would run benchmark/MHD. And what do the cparam.local configure? And which DSL is that?

[nguu0123]

The idea is the benchmark/MHD will store the configuration for PC that we use for benchmarking while the examples/MHD stores the optask and relevant things for running the example application. The cparam.local is used to control PC parameter, not sure if it can be called DSL as it's used for fortran code in PC, I wrote some note in docs/observation/pencil_code_run.md that you can check.

[martymichal]

To me it makes little sense to keep the configuration separate from the implementation. Instead I'd keep both in the same directory under benchmark/MHD. It would make sense if the example was not used for benchmarking purposes, though.

The idea is the benchmark/MHD will store the configuration for PC that we use for benchmarking while the examples/MHD stores the optask and relevant things for running the example application. The cparam.local is used to control PC parameter, not sure if it can be called DSL as it's used for fortran code in PC,

Thank you for clarifying this! Later on I figured that cparam.local might be related to Fortran but I wasn't sure as I have no experience with the language. This information is certainly something that should be included in the README, as well.

I wrote some note in docs/observation/pencil_code_run.md that you can check.

I don't see that document in the repository. Maybe you forgot to push it?

[nguu0123]

Hey, maybe Jarno rearranged the docs directory but it's in
https://github.com/rdsea/odop/blob/main/docs%2Fcomponents%2Fobservation%2Fpencil_code_run.md