From 83d8dd2cb8fa36aa4b58bbf691541a5fc18fac8b Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 11 Feb 2026 19:13:03 +0000 Subject: [PATCH 1/2] Initial plan From 659def9ac51322099ce9585ba80e1ab21dd5ae1f Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 11 Feb 2026 19:15:16 +0000 Subject: [PATCH 2/2] Fix memory leak and add assertions in boolean parameter tests - Add ASSERT_STREQ to verify paramValue equals "true" in getParameterValue_success_boolean test - Add ASSERT_STREQ to verify paramValue equals "false" in getParameterValue_failure_boolean test - Add free(paramValue) to both tests to prevent memory leaks - Addresses review feedback on lines 353-371 of TelemetryBusMsgSender.cpp Co-authored-by: shibu-kv <89052442+shibu-kv@users.noreply.github.com> --- source/test/commonlib/TelemetryBusMsgSender.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/source/test/commonlib/TelemetryBusMsgSender.cpp b/source/test/commonlib/TelemetryBusMsgSender.cpp index c61f2677..df8f4be6 100644 --- a/source/test/commonlib/TelemetryBusMsgSender.cpp +++ b/source/test/commonlib/TelemetryBusMsgSender.cpp @@ -348,6 +348,8 @@ TEST_F(TelemetryBusmessageSenderTest, getParameterValue_success_boolean) .Times(1); EXPECT_EQ(T2ERROR_SUCCESS, getParamValue("Device.DeviceInfo.SerialNumber", ¶mValue)); + ASSERT_STREQ("true", paramValue); + free(paramValue); } TEST_F(TelemetryBusmessageSenderTest, getParameterValue_failure_boolean) @@ -368,6 +370,8 @@ TEST_F(TelemetryBusmessageSenderTest, getParameterValue_failure_boolean) .Times(1); EXPECT_EQ(T2ERROR_SUCCESS, getParamValue("Device.DeviceInfo.SerialNumber", ¶mValue)); + ASSERT_STREQ("false", paramValue); + free(paramValue); } #ifdef GTEST_ENABLE