Conversation
Also, remove Fig, which was shut down in September 2024.
There was a problem hiding this comment.
I didn't know Fig had been shut down!
Since you are a Ghostty contributor, it feels a bit unfair to add only Ghostty in updating the list of projects. Today, many projects are relying on bash-preexec for their Bash integration. As far as I know, Warp also includes bash-preexec. Starship, VS Code Terminal, and Atuin also rely on bash-preexec as an option. Of course, it is not a complete list. Could you make an effort to search for projects that use bash-preexec and add them to the list? edit: Also, Bash-it and Oh-My-Bash use bash-preexec.
I mean, I get what you're saying, but at the same time I don't get why this PR isn't just merged. None of those other projects that are using bash-preexec have taken the time to come update this documentation. |
|
Happy to add this. We can also update the Readme to have a 'Used By' section to acknowledge all the dependent projects and who's leveraging bash-preexec. |
Also, remove Fig, which was shut down in September 2024.