From c1bdaece64af079af447b984c0233de142a48672 Mon Sep 17 00:00:00 2001 From: "google-labs-jules[bot]" <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Thu, 15 Jan 2026 17:56:20 +0000 Subject: [PATCH] Remove stopOnDomReady: false from isNewSidebar This change removes the `stopOnDomReady: false` option from the `elementReady` call in `isNewSidebar`. Previously, this option caused the application to wait indefinitely if the new sidebar selector was not found (e.g., for users on the old design), preventing the fallback logic from executing. By reverting to the default behavior (or essentially `stopOnDomReady: true`), the check will fail fast if the element is not found when the DOM is ready, allowing the application to correctly detect and handle the old design. The associated TODO comment has also been removed. --- source/browser.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/source/browser.ts b/source/browser.ts index eac7b77..33c781f 100644 --- a/source/browser.ts +++ b/source/browser.ts @@ -65,8 +65,7 @@ async function withMenu( } async function isNewSidebar(): Promise { - // TODO: stopOnDomReady might not be needed - await elementReady(selectors.leftSidebar, {stopOnDomReady: false}); + await elementReady(selectors.leftSidebar); const sidebars = document.querySelectorAll(selectors.leftSidebar);