From b5ea7212af88d187ae31d63f6b6c3cd903c143e7 Mon Sep 17 00:00:00 2001 From: Akihito Koriyama Date: Mon, 10 Nov 2025 10:52:47 +0900 Subject: [PATCH] Remove legacy doctrine annotation comments from provider classes This change addresses issue #33 by removing legacy doctrine annotation comments (@RedisConfig, @MemcacheConfig) from provider class docblocks. After migrating to PHP 8 attributes in version 1.5.0, these legacy annotations were causing AnnotationException when packages using koriym/attributes' DualReader attempted to parse them. Changes: - src/RedisProvider.php: Remove @RedisConfig("server") comment - src/MemcachedProvider.php: Remove @MemcacheConfig("servers") comment The PHP 8 attributes remain intact and functional. Type hints (@param) and documentation comments (@see) are preserved. Fixes #33 --- src/MemcachedProvider.php | 1 - src/RedisProvider.php | 6 +----- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/src/MemcachedProvider.php b/src/MemcachedProvider.php index 7ce8e83..157084e 100644 --- a/src/MemcachedProvider.php +++ b/src/MemcachedProvider.php @@ -14,7 +14,6 @@ class MemcachedProvider implements ProviderInterface /** * @param array> $servers * - * @MemcacheConfig("servers") * @see https://www.php.net/manual/en/memcached.addservers.php */ #[MemcacheConfig('servers')] diff --git a/src/RedisProvider.php b/src/RedisProvider.php index b536d65..1624c67 100644 --- a/src/RedisProvider.php +++ b/src/RedisProvider.php @@ -14,11 +14,7 @@ /** @implements ProviderInterface */ class RedisProvider implements ProviderInterface { - /** - * @param list $server - * - * @RedisConfig("server") - */ + /** @param list $server */ #[RedisConfig('server')] public function __construct(private array $server) {