Skip to content

verify-hardcoded-version: Check previous and next versions as well #122

@KyleFromNVIDIA

Description

@KyleFromNVIDIA

Suggested in this comment:

Since our version strings are a fixed format, could we update the check to look for more than just the current version? Our deprecation warnings usually include the current release version as well as the upcoming one. This would help avoid merging in code that won't cause pre-commit failures until the version is bumped. Just a suggestion.

There are two cases we would need to handle for this functionality:

  1. Semver versioning (ucxx)
  2. Calver versioning (the rest of RAPIDS)

Semver can be handled by going back one minor version and forward one minor version. Calver can be handled by subtracting 2 months and adding 2 months. We can add a --version-scheme argument that defaults to calver but can be set to semver.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions