Drop the static classes

[ramsey]

@agustingomes writes:¹

I would probably reconsider the Ramsey/Identifier/Uuid usage, and dropping it altogether.

When folks use ramsey/uuid they tend to do Uuid::v4 inside objects directly, just because of its convenience, unaware of the complexity they introduce that way.

I agree that the Ramsey\Identifier\Uuid and Ramsey\Identifier\Ulid static classes can lead to confusion and bad practices, so I'm inclined to follow this feedback.

To encourage best practices, I'm also considering dropping Ramsey\Identifier\Uuid\Factory and Ramsey\Identifier\Uuid\FactoryInterface. If coding to the interface, folks should accept any form of Identifier\Identifier, which could be fulfilled by any of the UUID or ULID factories provided in Ramsey\Identifier\Uuid\Factory or Ramsey\Identifier\Ulid\Factory through dependency injection.

Footnotes

1. https://twitter.com/agustingomes/status/1576500286780108802?s=20&t=lj0_dBx0baRQV8N_1fNpbg ↩

[deleugpn]

I agree that the Ramsey\Identifier\Uuid and Ramsey\Identifier\Ulid static classes can lead to confusion and bad practices

How?

[ramsey]

The primary problem being lack of deterministic testing in your unit tests because there’s no dependency injection. You can’t fully isolate the system under test from the external tools and libraries you use.

[ramsey]

I dropped the static classes in 5eb585c

[deleugpn]

I don't know what's your endgame plan is but I only see this as making it harder for ppl to easily migrate (Rector rule) from ramsey/uuid with little to no benefit for consumers

[ramsey]

The endgame is to write the library from scratch without impacting users of ramsey/uuid. ramsey/uuid is over 10 years old, and there are a lot of things about it I want to change or get rid of to improve both performance and maintainability. Unfortunately, if I make these changes in the next major version, it will cause too much upheaval in the ecosystem, so creating a separate library is best to allow both versions to exist at the same time. There will be no need to migrate from ramsey/uuid to ramsey/identifier, at least not in the foreseeable future.