PyXFocus.surfaces imports non-existant function from utilities

[ctderoo]

From PyXFocus.surfaces.py:

import utilities.imaging.zernikemod as zernikemod

This module does not exist in my copy of utilities. How do you want to resolve this -- take it out of utilities and put it into PyXFocus formally, or (eeek) work on merging our copies of utilities?

[rallured]

Hm? Oh god. What have you done with utilities?

I have updated my zernikemod to produce cleaner code and such that fitting images works similarly to the legendre routines. This stems from the fact that I wrote the original zernikemod very early in my SAO career, meaning my code was sloppier at that point. This module could honestly still use some cleaning up, probably, but the fitting functions are nicer.

[rallured]

Actually, I just skimmed through your version of utilities. It doesn't seem to have been updated since I left. Why don't you just switch to using my version like in PyXFocus?

[ctderoo]

It's been updated, but may be not pushed. I think the last time I modified utilities, I was just getting used to git, meaning that the changes are old and I didn't push them at the time. Let me do a pull request; there are some functions I'd like to keep and the comparison doesn't look that bad. Once you merge these functions into your version of utilities, I'll establish your version of utilities as the origin for my repository and we'll stop being on separate pages.

…

On Mon, Dec 11, 2017 at 3:36 PM, rallured ***@***.***> wrote: Actually, I just skimmed through your version of utilities. It doesn't seem to have been updated since I left. Why don't you just switch to using my version like in PyXFocus? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AWQyaO2TjzwrqrvlO1arx8CA_17HgnHQks5s_ZJUgaJpZM4Q9-S-> .

-- Dr. Casey DeRoo Astrophysicist Harvard-Smithsonian Center for Astrophysics

[rallured]

Ok, I think we're good to go. Our utilities are merged. On PyXFocus, I even merged a branch where I was working on WavefrontUpdate to my master, and then pushed that to the Github master.

What's odd is that I don't see a way to submit a pull request to get you and Ben to pull the updates.