[Bug] Block

[Vishiswaz]

Describe the bug

On the current TBC Anniversary version, RatingBuster is incorrectly seeing the "Block" value of a shield as "Block Rating". Block value = Amount of damage blocked when a block happens. Block rating = chance to block.

Addon Source

CurseForge

Version

2.0.9

Locale

English

Talent Specialization

Protection Paladin

Race

Blood Elf

[raethkcj]

Some notes for myself:

• We'll want to separate generated locales by expansion, since "%s block" is valid for rating in Cata onwards.
• BLOCK_RATING_SHORT is present as a GlobalString in TBC (and Vanilla) so we'll need to exclude it by TOC version in GlobalPatterns
• There's an unused enchant present in Vanilla, so we'll need to manually override it in StatLocaleData

[raethkcj]

Released a fix for this in Alpha on Curse and Wago. It should definitely fix it, I'm just releasing it as Alpha because it involved some shuffling around of locales that I want to make sure works fine, and I can't test myself until the PTR's back online.