From 7ef10e2916053ee045776ad8768a4485c7947ff0 Mon Sep 17 00:00:00 2001 From: yeskyu12 Date: Thu, 29 May 2025 23:13:18 +0900 Subject: [PATCH] =?UTF-8?q?refactor:=20naver=20maps=20api=20=EC=97=85?= =?UTF-8?q?=EB=8D=B0=EC=9D=B4=ED=8A=B8=EC=97=90=20=EB=94=B0=EB=A5=B8=20?= =?UTF-8?q?=EB=B3=80=EA=B2=BD=EC=82=AC=ED=95=AD=20=EB=B0=98=EC=98=81=20ncp?= =?UTF-8?q?ClientId=20->=20ncpKeyId=20https://navermaps.github.io/maps.js.?= =?UTF-8?q?ncp/docs/tutorial-2-Getting-Started.html?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/hooks/useNaverMapInit/index.ts | 10 +++++----- src/hooks/useNaverMapInit/types.ts | 2 +- ...iptByClientId.ts => createNaverMapScriptByKeyId.ts} | 8 ++++---- src/hooks/useNaverMapInit/utils/index.ts | 2 +- 4 files changed, 11 insertions(+), 11 deletions(-) rename src/hooks/useNaverMapInit/utils/{createNaverMapScriptByClientId.ts => createNaverMapScriptByKeyId.ts} (71%) diff --git a/src/hooks/useNaverMapInit/index.ts b/src/hooks/useNaverMapInit/index.ts index e866ee6..beccd02 100644 --- a/src/hooks/useNaverMapInit/index.ts +++ b/src/hooks/useNaverMapInit/index.ts @@ -4,7 +4,7 @@ import { useIsomorphicLayoutEffect } from "../useIsomorphicLayoutEffect"; import { SCRIPT_ID } from "./constants"; import type { InitResult, UseNaverMapInit } from "./types"; import { - createNaverMapScriptByClientId, + createNaverMapScriptByKeyId, insertNaverMapScriptIntoHead, } from "./utils"; @@ -17,7 +17,7 @@ import { * @param onError - This function will triggered when loading script failed. If 'onError' changes too often, wrap that definition in useCallback */ export const useNaverMapInit: UseNaverMapInit = ({ - ncpClientId, + ncpKeyId, submodules, onLoad, onError, @@ -39,8 +39,8 @@ export const useNaverMapInit: UseNaverMapInit = ({ const initNaverMapScript = async () => { const scriptInitResult = new Promise((resolve, reject) => { - const script = createNaverMapScriptByClientId({ - ncpClientId, + const script = createNaverMapScriptByKeyId({ + ncpKeyId: ncpKeyId, submodules, }); insertNaverMapScriptIntoHead(script); @@ -62,7 +62,7 @@ export const useNaverMapInit: UseNaverMapInit = ({ }; initNaverMapScript(); - }, [ncpClientId]); + }, [ncpKeyId]); useIsomorphicLayoutEffect(() => { if (onLoad && isFunction(onLoad) && isLoaded) { diff --git a/src/hooks/useNaverMapInit/types.ts b/src/hooks/useNaverMapInit/types.ts index d7cc30a..1680eb3 100644 --- a/src/hooks/useNaverMapInit/types.ts +++ b/src/hooks/useNaverMapInit/types.ts @@ -1,5 +1,5 @@ export interface InitParams { - ncpClientId: string; + ncpKeyId: string; submodules?: Submodule[] onLoad?: VoidFunction; onError?: VoidFunction; diff --git a/src/hooks/useNaverMapInit/utils/createNaverMapScriptByClientId.ts b/src/hooks/useNaverMapInit/utils/createNaverMapScriptByKeyId.ts similarity index 71% rename from src/hooks/useNaverMapInit/utils/createNaverMapScriptByClientId.ts rename to src/hooks/useNaverMapInit/utils/createNaverMapScriptByKeyId.ts index 26a965e..16029f0 100644 --- a/src/hooks/useNaverMapInit/utils/createNaverMapScriptByClientId.ts +++ b/src/hooks/useNaverMapInit/utils/createNaverMapScriptByKeyId.ts @@ -1,12 +1,12 @@ import { SCRIPT_ID } from "../constants"; import type { InitParams } from "../types"; -export const createNaverMapScriptByClientId = ({ - ncpClientId, +export const createNaverMapScriptByKeyId = ({ + ncpKeyId, submodules, -}: Pick) => { +}: Pick) => { const script = document.createElement("script"); - let paramsString = `ncpClientId=${ncpClientId}`; + let paramsString = `ncpKeyId=${ncpKeyId}`; if (submodules?.length) { paramsString = paramsString.concat(`&submodules=${submodules.join(",")}`); diff --git a/src/hooks/useNaverMapInit/utils/index.ts b/src/hooks/useNaverMapInit/utils/index.ts index e8a46b8..a934d08 100644 --- a/src/hooks/useNaverMapInit/utils/index.ts +++ b/src/hooks/useNaverMapInit/utils/index.ts @@ -1,2 +1,2 @@ -export * from "./createNaverMapScriptByClientId"; +export * from "./createNaverMapScriptByKeyId"; export * from "./insertNaverMapScriptIntoHead";