From 04b9e3e4da955ac01c8de50e525a2410983ce3b1 Mon Sep 17 00:00:00 2001 From: Michael Chirico Date: Thu, 8 May 2025 15:23:36 -0700 Subject: [PATCH 1/3] Skip tests depending on Suggests --- tests/testthat/test-full-seq.R | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/testthat/test-full-seq.R b/tests/testthat/test-full-seq.R index 7cbd901b..c2a7040b 100644 --- a/tests/testthat/test-full-seq.R +++ b/tests/testthat/test-full-seq.R @@ -32,6 +32,7 @@ test_that("works with Date", { }) test_that("works with hms/difftime", { + skip_if_not_installed("hms") x <- hms::hms(hours = 0:1) y <- as.difftime(c(0, 1800, 3600), units = "secs") expect_equal(fullseq(x, 1800), y) From 49a67ad063e005fa5cbe123c44ff99625b611d2d Mon Sep 17 00:00:00 2001 From: Michael Chirico Date: Thu, 8 May 2025 15:24:41 -0700 Subject: [PATCH 2/3] test-label-date.R: hms --- tests/testthat/test-label-date.R | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/testthat/test-label-date.R b/tests/testthat/test-label-date.R index 8d48f398..52bc2602 100644 --- a/tests/testthat/test-label-date.R +++ b/tests/testthat/test-label-date.R @@ -16,9 +16,11 @@ test_that("time_format works correctly", { na_time <- ISOdatetime(NA, 1, 1, 1, 1, 0) # time of value NA expect_equal(time_format()(a_time), "11:30:00") + expect_equal(time_format()(na_time), NA_character_ + + skip_if_not_installed("hms") expect_equal(time_format()(hms::as_hms(a_time)), "11:30:00") expect_equal(time_format(format = "%H")(hms::as_hms(a_time)), "11") - expect_equal(time_format()(na_time), NA_character_) }) test_that("can set locale", { From b36be387e88e0a0a11d71a6971ca6c39ee887c3d Mon Sep 17 00:00:00 2001 From: Michael Chirico Date: Thu, 8 May 2025 15:25:25 -0700 Subject: [PATCH 3/3] subtle requirement of stringi --- tests/testthat/test-label-date.R | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/testthat/test-label-date.R b/tests/testthat/test-label-date.R index 52bc2602..5ac4cbb5 100644 --- a/tests/testthat/test-label-date.R +++ b/tests/testthat/test-label-date.R @@ -30,6 +30,7 @@ test_that("can set locale", { }) test_that("label_date_short can replace leading zeroes", { + skip_if_not_installed("stringi") x <- seq(as.Date("2024-01-01"), as.Date("2025-01-01"), by = "1 month") labels <- label_date_short( format = c("%Y", "%m", "%d"),