Migrate httr to httr2 and Update Dependencies in devtools#2604
Closed
jhk0530 wants to merge 2 commits intor-lib:mainfrom
Closed
Migrate httr to httr2 and Update Dependencies in devtools#2604jhk0530 wants to merge 2 commits intor-lib:mainfrom
jhk0530 wants to merge 2 commits intor-lib:mainfrom
Conversation
see r-lib#2603 load_all, reexports have no modifications this time, but when you create a document, it will automatically reflect the previous modifications.
see r-lib#2602 I copied same upload_file function from httr to utils.R since httr2::req_body_multipart requires to input made by curl::form_file.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration from httr to httr2:
httrdependency withhttr2in relevant functions for better handling of HTTP requests.check_mac_release,upload_cran, etc.) to use httr2 APIs (request,req_body_multipart,req_perform, etc.).Dependency Updates:
httr2(≥ 1.1.2) andmime(≥ 0.13) toDESCRIPTION.NAMESPACEto include necessary imports fromhttr2,mime, and other packages.But, If it doesn't fit with the direction of the package, feel free to modify it with a Suggests
Note
Copied same
upload_file()function fromhttrtoutils.Rsincehttr2::req_body_multipartrequires to input made bycurl::form_file.R CMD Check was fine
source_urlwas finecheck_mac_releasewas finesubmit_cran(containsupload_cran) was fine, but need double check.