Skip to content

PulseTemplate identity based translation settings clash with "new" equality and hash implementation #935

@shumpohl

Description

@shumpohl

Before 9edd139, b41130e and others hashing and equality of pulse templates was only based on obejct identity.

The PulseTemplate.create_program argument to_single_waveform was designed with that in mind to target specific pulse templates in a pulse hirachy. With the above commits this behavior changed and all equal pulse templates get the same treatment even if used in a different context.

The new PulseTemplate.metadata attribute allows setting translation settings per pulse template which is the replacement for the above usecase.

We should modify to_single_waveform to only accept pulse identifiers again to avoid surprising behaviour.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions