[BUG] ConcurrentModificationException when calling usingRecipe() from within a cook() callback (ie usingRecipe is not Reentrant)

[lestephane]

Describe the bug
I called usingRecipe from within a cook() callback, because the callback receives a MapMaidBuilder, and MapMaidBuilder has a usingRecipe() method. A ConcurrentModificationException is thrown.

To Reproduce

private fun MapMaidBuilder.withBigDecimalMappingSupport(): MapMaidBuilder {
    return usingRecipe(BigDecimalMappingRecipe)
}

private object BigDecimalMappingRecipe : Recipe {
    override fun cook(mapMaidBuilder: MapMaidBuilder) {
        mapMaidBuilder.serializingAndDeserializing(
            DuplexType.customPrimitive(
                BigDecimal::class.java,
                { it.toPlainString() },
                { BigDecimal(it) }
            )
        )
    }
}

private object ReproductionMappingConfiguration : Recipe {
    override fun cook(mapMaidBuilder: MapMaidBuilder) {
        mapMaidBuilder.withBigDecimalMappingSupport()
    }
}

fun main() {
    MapMaid.aMapMaid().usingRecipe(ReproductionMappingConfiguration).build().serializeToJson(BigDecimal(1))
}

Expected behavior

• If the cook() callback does not support calling usingRecipe(), then it should not be given a MapMaidBuilder, but rather a subset of only those operations that are allowed at that point.
• If the cook() callback sould support calling usingRecipe(), then it should work without throwing a ConcurrentModificationException

Environment description

• project version used: 0.9.108
• Java version used: N/A

[lestephane]

Clarified that the issue is that usingRecipe() is not reentrant, making composition of one Recipe from other Recipes exhibit this problem.

The workaround is not to use usingRecipe() from withing the cook() method, but to call the composed Recipes' cook() method directly.

Not a tragedy, just not fluent anymore

Desired fluent invocation

builder.usingRecipe(SomeRecipe).with..

Invocation with workaround

builder.with..
SomeRecipe.cook(builder)