Skip to content

Commit 3350921

Browse files
committed
fix: exclude .js/.mjs/.cjs from cleanup patterns to prevent deleting bundled chunks\n\nRoot cause: HISTORY* pattern case-insensitively matches Vite/Rollup code chunks\nlike history-CMXy8eH-.js on Windows, breaking the installed package.\nSame issue likely caused the changelog.js deletion (CHANGELOG* pattern).
1 parent c32ad2d commit 3350921

3 files changed

Lines changed: 5 additions & 4 deletions

File tree

.github/workflows/build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ jobs:
183183
-name "Makefile" -o \
184184
-name ".editorconfig" -o \
185185
-name ".travis.yml" \
186-
\) -delete 2>/dev/null || true
186+
\) ! -name "*.js" ! -name "*.mjs" ! -name "*.cjs" -delete 2>/dev/null || true
187187
find "build/${{ matrix.platform }}/node_modules" -type d \( \
188188
-name "test" -o -name "tests" -o -name "__tests__" -o \
189189
-name "spec" -o -name "example" -o -name "examples" -o \
@@ -202,7 +202,7 @@ jobs:
202202
$dirPatterns = @("test", "tests", "__tests__", "spec", "example", "examples", ".github", ".circleci")
203203
foreach ($p in $patterns) {
204204
Get-ChildItem -Path $nmDir -Recurse -Filter $p -File -ErrorAction SilentlyContinue |
205-
Where-Object { $_.Name -notlike "*.d.ts" } |
205+
Where-Object { $_.Name -notlike "*.d.ts" -and $_.Extension -notin @('.js', '.mjs', '.cjs') } |
206206
Remove-Item -Force -ErrorAction SilentlyContinue
207207
}
208208
foreach ($d in $dirPatterns) {

scripts/package-unix.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ find "$BUILD_DIR/node_modules" -type f \( \
155155
-name "Makefile" -o \
156156
-name ".editorconfig" -o \
157157
-name ".travis.yml" \
158-
\) -delete 2>/dev/null || true
158+
\) ! -name "*.js" ! -name "*.mjs" ! -name "*.cjs" -delete 2>/dev/null || true
159159

160160
# Remove unnecessary directories
161161
find "$BUILD_DIR/node_modules" -type d \( \

scripts/package-win.ps1

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,8 @@ $cleanPatterns = @(
134134
)
135135
$savedMB = 0
136136
foreach ($pattern in $cleanPatterns) {
137-
$items = Get-ChildItem -Path "$BuildDir\node_modules" -Recurse -Filter $pattern -ErrorAction SilentlyContinue
137+
$items = Get-ChildItem -Path "$BuildDir\node_modules" -Recurse -Filter $pattern -ErrorAction SilentlyContinue |
138+
Where-Object { $_.Extension -notin @('.js', '.mjs', '.cjs') }
138139
foreach ($item in $items) {
139140
$savedMB += $item.Length / 1MB
140141
Remove-Item -Recurse -Force $item.FullName -ErrorAction SilentlyContinue

0 commit comments

Comments
 (0)