Skip to content

Commit b8562dd

Browse files
authored
Merge pull request #124 from shubhbapna/host-env-to-build-step
fix: pass environment variables from caller to build steps
2 parents 2f3ac4b + 243d7cd commit b8562dd

File tree

3 files changed

+18
-2
lines changed

3 files changed

+18
-2
lines changed

src/fromager/overrides.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ def extra_environ_for_pkg(
6868
6969
Extra environment variables are stored in per-package .env files in the
7070
envs package, with a key=value per line.
71-
7271
"""
7372
extra_environ = {}
7473

src/fromager/wheels.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ def default_build_wheel(
111111
if existing_path:
112112
path_parts.append(existing_path)
113113
updated_path = ":".join(path_parts)
114-
override_env = {}
114+
override_env = dict(os.environ)
115115
override_env.update(extra_environ)
116116
override_env["PATH"] = updated_path
117117
override_env["VIRTUAL_ENV"] = str(build_env.path)

tests/test_overrides.py

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,3 +38,20 @@ def test_patches_for_source_dir(tmp_path: pathlib.Path):
3838
overrides.patches_for_source_dir(patches_dir, "project-1.2.3-variant")
3939
)
4040
assert results == [p2, p5]
41+
42+
43+
def test_extra_environ_for_pkg(tmp_path: pathlib.Path):
44+
env_dir = tmp_path / "env"
45+
env_dir.mkdir()
46+
47+
variant_dir = env_dir / "variant"
48+
variant_dir.mkdir()
49+
50+
project_env = variant_dir / "project.env"
51+
project_env.write_text("VAR1=VALUE1\nVAR2=VALUE2")
52+
53+
result = overrides.extra_environ_for_pkg(env_dir, "project", "variant")
54+
assert result == {"VAR1": "VALUE1", "VAR2": "VALUE2"}
55+
56+
result = overrides.extra_environ_for_pkg(env_dir, "non_existant_project", "variant")
57+
assert result == {}

0 commit comments

Comments
 (0)