From f16120eae300caa063c2a6f93b0e1e363765e6b3 Mon Sep 17 00:00:00 2001 From: Simon Perkins Date: Wed, 21 May 2025 16:50:12 +0200 Subject: [PATCH 1/2] Add is_unlimited argument to AbstractWritableStore.set_dimension --- xarray/backends/common.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xarray/backends/common.py b/xarray/backends/common.py index 58a98598a5b..57ecf65704b 100644 --- a/xarray/backends/common.py +++ b/xarray/backends/common.py @@ -402,7 +402,7 @@ def encode_attribute(self, a): """encode one attribute""" return a - def set_dimension(self, dim, length): # pragma: no cover + def set_dimension(self, dim, length, is_unlimited): # pragma: no cover raise NotImplementedError() def set_attribute(self, k, v): # pragma: no cover From 335e8e905bf1362a1fb8208f1ed7bc1e7edb7cab Mon Sep 17 00:00:00 2001 From: Simon Perkins Date: Wed, 21 May 2025 16:51:17 +0200 Subject: [PATCH 2/2] Add missing AbstractWritableDataStore.prepare_variable method --- xarray/backends/common.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xarray/backends/common.py b/xarray/backends/common.py index 57ecf65704b..2fef2c0370c 100644 --- a/xarray/backends/common.py +++ b/xarray/backends/common.py @@ -402,6 +402,9 @@ def encode_attribute(self, a): """encode one attribute""" return a + def prepare_variable(self, name, variable, check_encoding, unlimited_dims): + raise NotImplementedError() + def set_dimension(self, dim, length, is_unlimited): # pragma: no cover raise NotImplementedError()