Update test expectations for prometheus metric name changes

Author: smahima27

spec/unit/pool_manager_spec.rb

@@ -1107,7 +1107,8 @@
     context 'with no errors during cloning' do
       before(:each) do
         allow(metrics).to receive(:timing)
-        expect(metrics).to receive(:timing).with(/clone\./,/0/)
+        allow(metrics).to receive(:gauge)
+        expect(metrics).to receive(:gauge).with(/vmpooler_clone\./,/0/)
         expect(provider).to receive(:create_vm).with(pool, String)
         allow(provider).to receive(:get_vm_ip_address).and_return(1)
         allow(subject).to receive(:get_domain_for_pool).and_return('example.com')
@@ -1158,7 +1159,8 @@
     context 'with a failure to get ip address after cloning' do
       it 'should log a message that it completed being cloned' do
         allow(metrics).to receive(:timing)
-        expect(metrics).to receive(:timing).with(/clone\./,/0/)
+        allow(metrics).to receive(:gauge)
+        expect(metrics).to receive(:gauge).with(/vmpooler_clone\./,/0/)
         expect(provider).to receive(:create_vm).with(pool, String)
         allow(provider).to receive(:get_vm_ip_address).and_return(nil)
 
@@ -1217,7 +1219,8 @@
     context 'with request_id' do
       before(:each) do
         allow(metrics).to receive(:timing)
-        expect(metrics).to receive(:timing).with(/clone\./,/0/)
+        allow(metrics).to receive(:gauge)
+        expect(metrics).to receive(:gauge).with(/vmpooler_clone\./,/0/)
         expect(provider).to receive(:create_vm).with(pool, String)
         allow(provider).to receive(:get_vm_ip_address).with(vm,pool).and_return(1)
         allow(subject).to receive(:get_dns_plugin_class_name_for_pool).and_return(dns_plugin)
@@ -1353,7 +1356,8 @@
       it 'should emit a timing metric' do
         allow(subject).to receive(:get_vm_usage_labels)
         allow(metrics).to receive(:timing)
-        expect(metrics).to receive(:timing).with("vmpooler_destroy.#{pool}", String)
+        allow(metrics).to receive(:gauge)
+        expect(metrics).to receive(:gauge).with("vmpooler_destroy.#{pool}", String)
 
         subject._destroy_vm(vm,pool,provider,dns_plugin)
       end

spec/unit/queue_reliability_spec.rb

@@ -223,7 +223,7 @@
 
         it 'increments purge metrics' do
           redis_connection_pool.with do |redis_connection|
-            expect(metrics).to receive(:increment).with("purge.pending.#{pool}.count")
+            expect(metrics).to receive(:increment).with("vmpooler_purge.pending.#{pool}.count")
 
             subject.purge_pending_queue(pool, redis_connection)
           end
@@ -460,35 +460,35 @@
 
       it 'pushes status metric' do
         allow(metrics).to receive(:gauge)
-        expect(metrics).to receive(:gauge).with('health.status', 0)
+        expect(metrics).to receive(:gauge).with('vmpooler_health.status', 0)
 
         subject.push_health_metrics(metrics_data, 'healthy')
       end
 
       it 'pushes error metrics' do
         allow(metrics).to receive(:gauge)
-        expect(metrics).to receive(:gauge).with('health.dlq.total_size', 25)
-        expect(metrics).to receive(:gauge).with('health.stuck_vms.count', 2)
-        expect(metrics).to receive(:gauge).with('health.orphaned_metadata.count', 3)
+        expect(metrics).to receive(:gauge).with('vmpooler_health.dlq.total_size', 25)
+        expect(metrics).to receive(:gauge).with('vmpooler_health.stuck_vms.count', 2)
+        expect(metrics).to receive(:gauge).with('vmpooler_health.orphaned_metadata.count', 3)
 
         subject.push_health_metrics(metrics_data, 'healthy')
       end
 
       it 'pushes per-pool queue metrics' do
         allow(metrics).to receive(:gauge)
-        expect(metrics).to receive(:gauge).with('health.queue.test-pool.pending.size', 10)
-        expect(metrics).to receive(:gauge).with('health.queue.test-pool.pending.oldest_age', 3600)
-        expect(metrics).to receive(:gauge).with('health.queue.test-pool.pending.stuck_count', 2)
-        expect(metrics).to receive(:gauge).with('health.queue.test-pool.ready.size', 50)
+        expect(metrics).to receive(:gauge).with('vmpooler_health.queue.test-pool.pending.size', 10)
+        expect(metrics).to receive(:gauge).with('vmpooler_health.queue.test-pool.pending.oldest_age', 3600)
+        expect(metrics).to receive(:gauge).with('vmpooler_health.queue.test-pool.pending.stuck_count', 2)
+        expect(metrics).to receive(:gauge).with('vmpooler_health.queue.test-pool.ready.size', 50)
 
         subject.push_health_metrics(metrics_data, 'healthy')
       end
 
       it 'pushes task metrics' do
         allow(metrics).to receive(:gauge)
-        expect(metrics).to receive(:gauge).with('health.tasks.clone.active', 3)
-        expect(metrics).to receive(:gauge).with('health.tasks.ondemand.active', 2)
-        expect(metrics).to receive(:gauge).with('health.tasks.ondemand.pending', 5)
+        expect(metrics).to receive(:gauge).with('vmpooler_health.tasks.clone.active', 3)
+        expect(metrics).to receive(:gauge).with('vmpooler_health.tasks.ondemand.active', 2)
+        expect(metrics).to receive(:gauge).with('vmpooler_health.tasks.ondemand.pending', 5)
 
         subject.push_health_metrics(metrics_data, 'healthy')
       end