From 27058f16474820f307fba1d991bbd57017baf812 Mon Sep 17 00:00:00 2001 From: Josh Cooper Date: Thu, 16 Jan 2025 16:54:19 -0800 Subject: [PATCH 1/2] (PA-6897) Bump voxpupuli-rubocop Earlier versions of voxpupuli-rubocop resolve to rubocop-factory_bot 2.26.0 that causes this error: ``` $ bundle exec rubocop Error: Property AutoCorrect of cop FactoryBot/CreateList is supposed to be a boolean and contextual is not ``` See https://github.com/rubocop/rubocop-rspec/issues/1916 Update to newer voxpupuli-rubocop to avoid this issue. --- beaker-puppet.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/beaker-puppet.gemspec b/beaker-puppet.gemspec index b0bdae8..731b354 100644 --- a/beaker-puppet.gemspec +++ b/beaker-puppet.gemspec @@ -23,7 +23,7 @@ Gem::Specification.new do |s| s.add_development_dependency 'rake', '~> 13.0' s.add_development_dependency 'rspec', '~> 3.0' s.add_development_dependency 'rspec-its', '~> 1.3' - s.add_development_dependency 'voxpupuli-rubocop', '~> 2.1.0' + s.add_development_dependency 'voxpupuli-rubocop', '~> 3.0' # Acceptance Testing Dependencies s.add_development_dependency 'beaker-vmpooler', '~> 1.4' From 11a25b0c525d7378585315e8260236f2e2148cc3 Mon Sep 17 00:00:00 2001 From: Josh Cooper Date: Thu, 16 Jan 2025 17:06:29 -0800 Subject: [PATCH 2/2] (PA-6897) Regenerate .rubocop_todo.yml bundle exec rubocop --auto-gen-config --- .rubocop_todo.yml | 406 ++++++++++++++++++++++++++++++++++++---------- 1 file changed, 323 insertions(+), 83 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 5b52fec..62804b7 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,11 +1,19 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2023-12-19 12:29:40 UTC using RuboCop version 1.57.2. +# on 2025-01-17 01:06:09 UTC using RuboCop version 1.67.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: Include. +# Include: **/*.gemspec +Gemspec/AddRuntimeDependency: + Exclude: + - 'beaker-puppet.gemspec' + # Offense count: 1 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: Severity, Include. @@ -14,6 +22,103 @@ Gemspec/DeprecatedAttributeAssignment: Exclude: - 'beaker-puppet.gemspec' +# Offense count: 4 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle, IndentOneStep, IndentationWidth. +# SupportedStyles: case, end +Layout/CaseIndentation: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + +# Offense count: 5 +# This cop supports safe autocorrection (--autocorrect). +Layout/EmptyLineAfterGuardClause: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines, beginning_only, ending_only +Layout/EmptyLinesAroundClassBody: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyleAlignWith, Severity. +# SupportedStylesAlignWith: keyword, variable, start_of_line +Layout/EndAlignment: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + +# Offense count: 3 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment. +Layout/ExtraSpacing: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Layout/HeredocIndentation: + Exclude: + - 'setup/common/003_solaris_cert_fix.rb' + +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: Width, AllowedPatterns. +Layout/IndentationWidth: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowDoxygenCommentStyle, AllowGemfileRubyComment, AllowRBSInlineAnnotation. +Layout/LeadingCommentSpace: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + +# Offense count: 9 +# This cop supports safe autocorrection (--autocorrect). +Layout/SpaceAfterComma: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator, EnforcedStyleForRationalLiterals. +# SupportedStylesForExponentOperator: space, no_space +# SupportedStylesForRationalLiterals: space, no_space +Layout/SpaceAroundOperators: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + +# Offense count: 14 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters. +# SupportedStyles: space, no_space +# SupportedStylesForEmptyBraces: space, no_space +Layout/SpaceInsideBlockBraces: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + +# Offense count: 40 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: space, compact, no_space +Layout/SpaceInsideParens: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: final_newline, final_blank_line +Layout/TrailingEmptyLines: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + # Offense count: 2 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowedMethods, AllowedPatterns. @@ -103,12 +208,6 @@ Lint/ShadowingOuterLocalVariable: Exclude: - 'lib/beaker-puppet/helpers/puppet_helpers.rb' -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -Lint/UnifiedInteger: - Exclude: - - 'spec/beaker-puppet/helpers/facter_helpers_spec.rb' - # Offense count: 1 # Configuration parameters: AllowedPatterns. # AllowedPatterns: (?-mix:(exactly|at_least|at_most)\(\d+\)\.times) @@ -118,7 +217,7 @@ Lint/UnreachableLoop: # Offense count: 19 # This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments. +# Configuration parameters: AutoCorrect, IgnoreEmptyBlocks, AllowUnusedKeywordArguments. Lint/UnusedBlockArgument: Exclude: - 'lib/beaker-puppet/helpers/puppet_helpers.rb' @@ -133,14 +232,15 @@ Lint/UnusedBlockArgument: # Offense count: 3 # This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods. +# Configuration parameters: AutoCorrect, AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods. Lint/UnusedMethodArgument: Exclude: - 'lib/beaker-puppet/helpers/puppet_helpers.rb' - 'spec/beaker-puppet/install_utils/windows_utils_spec.rb' -# Offense count: 17 -# This cop supports unsafe autocorrection (--autocorrect-all). +# Offense count: 13 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AutoCorrect. Lint/UselessAssignment: Exclude: - 'acceptance/tests/clone_git_repo_on_test.rb' @@ -162,7 +262,7 @@ Naming/AccessorMethodName: Exclude: - 'Rakefile' -# Offense count: 5 +# Offense count: 6 Naming/ConstantName: Exclude: - 'lib/beaker-puppet/install_utils/foss_utils.rb' @@ -191,6 +291,17 @@ Naming/HeredocDelimiterNaming: - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb' - 'tasks/ci.rake' +# Offense count: 1 +# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros. +# NamePrefix: is_, has_, have_ +# ForbiddenPrefixes: is_, has_, have_ +# AllowedMethods: is_a? +# MethodDefinitionMacros: define_method, define_singleton_method +Naming/PredicateName: + Exclude: + - 'spec/**/*' + - 'lib/beaker-puppet/inifile.rb' + # Offense count: 7 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: PreferredName. @@ -209,12 +320,6 @@ Naming/VariableNumber: - 'lib/beaker-puppet/install_utils/foss_utils.rb' - 'setup/git/000_EnvSetup.rb' -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -Performance/BlockGivenWithExplicitBlock: - Exclude: - - 'lib/beaker-puppet/helpers/puppet_helpers.rb' - # Offense count: 1 # Configuration parameters: MinSize. Performance/CollectionLiteralInLoop: @@ -241,7 +346,7 @@ Performance/RedundantMerge: Exclude: - 'lib/beaker-puppet/helpers/facter_helpers.rb' -# Offense count: 43 +# Offense count: 41 # This cop supports safe autocorrection (--autocorrect). Performance/RegexpMatch: Exclude: @@ -258,7 +363,20 @@ Performance/RegexpMatch: - 'setup/gem/010_GemInstall.rb' - 'setup/git/000_EnvSetup.rb' -# Offense count: 30 +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: SafeMultiline. +Performance/StartWith: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Performance/StringIdentifierArgument: + Exclude: + - 'spec/beaker-puppet/wrappers_spec.rb' + +# Offense count: 28 # This cop supports unsafe autocorrection (--autocorrect-all). Performance/StringInclude: Exclude: @@ -299,7 +417,7 @@ RSpec/ContextMethod: Exclude: - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb' -# Offense count: 52 +# Offense count: 41 # Configuration parameters: Prefixes, AllowedPatterns. # Prefixes: when, with, without RSpec/ContextWording: @@ -311,7 +429,7 @@ RSpec/ContextWording: - 'spec/beaker-puppet/install_utils/puppet_utils_spec.rb' - 'spec/beaker-puppet/install_utils/windows_utils_spec.rb' -# Offense count: 24 +# Offense count: 22 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowConsecutiveOneLiners. RSpec/EmptyLineAfterExample: @@ -327,7 +445,7 @@ RSpec/EmptyLineAfterExampleGroup: - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb' - 'spec/beaker-puppet/install_utils/module_utils_spec.rb' -# Offense count: 19 +# Offense count: 16 # This cop supports safe autocorrection (--autocorrect). RSpec/EmptyLineAfterFinalLet: Exclude: @@ -336,12 +454,11 @@ RSpec/EmptyLineAfterFinalLet: - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb' - 'spec/beaker-puppet/install_utils/module_utils_spec.rb' -# Offense count: 4 +# Offense count: 3 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowConsecutiveOneLiners. RSpec/EmptyLineAfterHook: Exclude: - - 'spec/beaker-puppet/helpers/puppet_helpers_spec.rb' - 'spec/beaker-puppet/helpers/tk_helpers_spec.rb' - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb' @@ -351,12 +468,12 @@ RSpec/Eq: Exclude: - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb' -# Offense count: 138 +# Offense count: 113 # Configuration parameters: CountAsOne. RSpec/ExampleLength: - Max: 34 + Max: 30 -# Offense count: 24 +# Offense count: 34 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: CustomTransform, IgnoredWords, DisallowedExamples. # DisallowedExamples: works @@ -365,32 +482,16 @@ RSpec/ExampleWording: - 'spec/beaker-puppet/install_utils/ezbake_utils_spec.rb' - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb' - 'spec/beaker-puppet/install_utils/module_utils_spec.rb' + - 'spec/beaker-puppet/install_utils/windows_utils_spec.rb' - 'spec/beaker-puppet/wrappers_spec.rb' -# Offense count: 8 +# Offense count: 4 RSpec/ExpectInHook: Exclude: - 'spec/beaker-puppet/helpers/puppet_helpers_spec.rb' - 'spec/beaker-puppet/helpers/tk_helpers_spec.rb' -# Offense count: 11 -# Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly. -# Include: **/*_spec*rb*, **/spec/**/* -RSpec/FilePath: - Exclude: - - 'spec/beaker-puppet/helpers/facter_helpers_spec.rb' - - 'spec/beaker-puppet/helpers/host_helpers_spec.rb' - - 'spec/beaker-puppet/helpers/puppet_helpers_spec.rb' - - 'spec/beaker-puppet/helpers/tk_helpers_spec.rb' - - 'spec/beaker-puppet/install_utils/ezbake_utils_spec.rb' - - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb' - - 'spec/beaker-puppet/install_utils/module_utils_spec.rb' - - 'spec/beaker-puppet/install_utils/puppet5_spec.rb' - - 'spec/beaker-puppet/install_utils/puppet_utils_spec.rb' - - 'spec/beaker-puppet/install_utils/windows_utils_spec.rb' - - 'spec/beaker-puppet/wrappers_spec.rb' - -# Offense count: 26 +# Offense count: 22 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: implicit, each, example @@ -408,7 +509,7 @@ RSpec/IndexedLet: Exclude: - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb' -# Offense count: 14 +# Offense count: 12 # Configuration parameters: AssignmentOnly. RSpec/InstanceVariable: Exclude: @@ -428,13 +529,7 @@ RSpec/IteratedExpectation: Exclude: - 'spec/beaker-puppet/install_utils/windows_utils_spec.rb' -# Offense count: 1 -# This cop supports safe autocorrection (--autocorrect). -RSpec/LetBeforeExamples: - Exclude: - - 'spec/beaker-puppet/helpers/puppet_helpers_spec.rb' - -# Offense count: 508 +# Offense count: 412 # Configuration parameters: EnforcedStyle. # SupportedStyles: have_received, receive RSpec/MessageSpies: @@ -450,16 +545,16 @@ RSpec/MessageSpies: - 'spec/beaker-puppet/install_utils/windows_utils_spec.rb' - 'spec/beaker-puppet/wrappers_spec.rb' -# Offense count: 183 +# Offense count: 147 RSpec/MultipleExpectations: - Max: 12 + Max: 8 -# Offense count: 150 +# Offense count: 134 # Configuration parameters: AllowSubject. RSpec/MultipleMemoizedHelpers: Max: 25 -# Offense count: 940 +# Offense count: 800 # Configuration parameters: EnforcedStyle, IgnoreSharedExamples. # SupportedStyles: always, named_only RSpec/NamedSubject: @@ -476,23 +571,21 @@ RSpec/NamedSubject: - 'spec/beaker-puppet/install_utils/windows_utils_spec.rb' - 'spec/beaker-puppet/wrappers_spec.rb' -# Offense count: 31 +# Offense count: 21 # Configuration parameters: AllowedGroups. RSpec/NestedGroups: Max: 5 -# Offense count: 8 +# Offense count: 4 # Configuration parameters: AllowedPatterns. # AllowedPatterns: ^expect_, ^assert_ RSpec/NoExpectationExample: Exclude: - - 'spec/beaker-puppet/helpers/puppet_helpers_spec.rb' - 'spec/beaker-puppet/helpers/tk_helpers_spec.rb' - 'spec/beaker-puppet/install_utils/ezbake_utils_spec.rb' - - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb' - 'spec/beaker-puppet/install_utils/module_utils_spec.rb' -# Offense count: 10 +# Offense count: 8 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: not_to, to_not @@ -502,14 +595,14 @@ RSpec/NotToNot: - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb' - 'spec/beaker-puppet/install_utils/module_utils_spec.rb' -# Offense count: 24 +# Offense count: 16 # This cop supports safe autocorrection (--autocorrect). RSpec/ReceiveCounts: Exclude: - 'spec/beaker-puppet/helpers/puppet_helpers_spec.rb' - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb' -# Offense count: 66 +# Offense count: 64 # This cop supports unsafe autocorrection (--autocorrect-all). RSpec/ReceiveMessages: Exclude: @@ -534,7 +627,7 @@ RSpec/RepeatedDescription: - 'spec/beaker-puppet/helpers/puppet_helpers_spec.rb' - 'spec/beaker-puppet/install_utils/puppet5_spec.rb' -# Offense count: 33 +# Offense count: 25 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: and_return, block @@ -562,7 +655,13 @@ RSpec/SpecFilePathFormat: - 'spec/beaker-puppet/install_utils/windows_utils_spec.rb' - 'spec/beaker-puppet/wrappers_spec.rb' -# Offense count: 106 +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +RSpec/StringAsInstanceDoubleConstant: + Exclude: + - 'spec/beaker-puppet/install_utils/module_utils_spec.rb' + +# Offense count: 88 RSpec/StubbedMock: Exclude: - 'spec/beaker-puppet/helpers/facter_helpers_spec.rb' @@ -574,7 +673,7 @@ RSpec/StubbedMock: - 'spec/beaker-puppet/install_utils/puppet_utils_spec.rb' - 'spec/beaker-puppet/install_utils/windows_utils_spec.rb' -# Offense count: 593 +# Offense count: 501 RSpec/SubjectStub: Exclude: - 'spec/beaker-puppet/helpers/facter_helpers_spec.rb' @@ -596,11 +695,10 @@ RSpec/VerifiedDoubleReference: Exclude: - 'spec/beaker-puppet/install_utils/module_utils_spec.rb' -# Offense count: 9 +# Offense count: 5 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames. RSpec/VerifiedDoubles: Exclude: - - 'spec/beaker-puppet/helpers/puppet_helpers_spec.rb' - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb' - 'spec/beaker-puppet/install_utils/module_utils_spec.rb' - 'spec/helpers.rb' @@ -648,7 +746,23 @@ Security/YAMLLoad: Exclude: - 'lib/beaker-puppet/install_utils/foss_utils.rb' -# Offense count: 6 +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: separated, grouped +Style/AccessorGrouping: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + +# Offense count: 3 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: prefer_alias, prefer_alias_method +Style/Alias: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + +# Offense count: 5 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: always, conditionals @@ -657,6 +771,17 @@ Style/AndOr: - 'lib/beaker-puppet/install_utils/foss_utils.rb' - 'lib/beaker-puppet/install_utils/puppet_utils.rb' +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, AllowedMethods, AllowedPatterns, AllowBracesOnProceduralOneLiners, BracesRequiredMethods. +# SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces +# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object +# FunctionalMethods: let, let!, subject, watch +# AllowedMethods: lambda, proc, it +Style/BlockDelimiters: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + # Offense count: 10 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowOnConstant, AllowOnSelfClass. @@ -667,20 +792,20 @@ Style/CaseEquality: - 'spec/beaker-puppet/install_utils/puppet5_spec.rb' - 'spec/beaker-puppet/install_utils/windows_utils_spec.rb' -# Offense count: 3 +# Offense count: 1 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: MinBranchesCount. Style/CaseLikeIf: Exclude: - 'lib/beaker-puppet/install_utils/foss_utils.rb' - - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb' -# Offense count: 1 +# Offense count: 2 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: nested, compact Style/ClassAndModuleChildren: Exclude: + - 'lib/beaker-puppet/inifile.rb' - 'spec/beaker-puppet/install_utils/ezbake_utils_spec.rb' # Offense count: 1 @@ -696,6 +821,12 @@ Style/CombinableLoops: Exclude: - 'spec/beaker-puppet/install_utils/windows_utils_spec.rb' +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +Style/CommentedKeyword: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + # Offense count: 3 # Configuration parameters: AllowedConstants. Style/Documentation: @@ -706,12 +837,30 @@ Style/Documentation: - 'lib/beaker-puppet/install_utils/puppet5.rb' - 'lib/beaker-puppet/wrappers.rb' +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +Style/EmptyLiteral: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Style/Encoding: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + # Offense count: 1 # This cop supports unsafe autocorrection (--autocorrect-all). Style/EnvHome: Exclude: - 'acceptance/config/acceptance-options.rb' +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Style/ExplicitBlockArgument: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + # Offense count: 20 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: MaxUnannotatedPlaceholdersAllowed, AllowedMethods, AllowedPatterns. @@ -719,19 +868,29 @@ Style/EnvHome: Style/FormatStringToken: EnforcedStyle: unannotated -# Offense count: 74 +# Offense count: 75 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: always, always_true, never Style/FrozenStringLiteralComment: Enabled: false -# Offense count: 1 +# Offense count: 2 # Configuration parameters: MinBranchesCount. Style/HashLikeCase: Exclude: + - 'lib/beaker-puppet/inifile.rb' - 'lib/beaker-puppet/install_utils/windows_utils.rb' +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle, EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols. +# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys +# SupportedShorthandSyntax: always, never, either, consistent, either_consistent +Style/HashSyntax: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + # Offense count: 4 # This cop supports unsafe autocorrection (--autocorrect-all). Style/IdenticalConditionalBranches: @@ -739,7 +898,7 @@ Style/IdenticalConditionalBranches: - 'lib/beaker-puppet/helpers/tk_helpers.rb' - 'lib/beaker-puppet/install_utils/ezbake_utils.rb' -# Offense count: 13 +# Offense count: 12 # This cop supports safe autocorrection (--autocorrect). Style/IfUnlessModifier: Exclude: @@ -756,6 +915,12 @@ Style/LineEndConcatenation: - 'lib/beaker-puppet/helpers/puppet_helpers.rb' - 'lib/beaker-puppet/install_utils/foss_utils.rb' +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +Style/MapIntoArray: + Exclude: + - 'acceptance/pre_suite/git/install.rb' + # Offense count: 1 # This cop supports unsafe autocorrection (--autocorrect-all). Style/MapToHash: @@ -767,7 +932,7 @@ Style/MixinUsage: Exclude: - 'tasks/ci.rake' -# Offense count: 37 +# Offense count: 39 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: literals, strict @@ -807,13 +972,27 @@ Style/OptionalBooleanParameter: - 'Rakefile' - 'lib/beaker-puppet/helpers/tk_helpers.rb' -# Offense count: 8 +# Offense count: 19 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: PreferredDelimiters. +Style/PercentLiteralDelimiters: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + +# Offense count: 11 +# This cop supports safe autocorrection (--autocorrect). +Style/PerlBackrefs: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + +# Offense count: 9 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: short, verbose Style/PreferredHashMethods: Exclude: - 'lib/beaker-puppet/helpers/puppet_helpers.rb' + - 'lib/beaker-puppet/inifile.rb' - 'lib/beaker-puppet/install_utils/foss_utils.rb' - 'lib/beaker-puppet/install_utils/module_utils.rb' - 'spec/helpers.rb' @@ -826,7 +1005,7 @@ Style/RedundantArgument: - 'Rakefile' - 'tasks/ci.rake' -# Offense count: 17 +# Offense count: 9 # This cop supports unsafe autocorrection (--autocorrect-all). Style/RedundantInterpolation: Exclude: @@ -838,6 +1017,44 @@ Style/RedundantInterpolation: - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb' - 'tasks/ci.rake' +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +Style/RedundantLineContinuation: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Style/RedundantParentheses: + Exclude: + - 'setup/git/000_EnvSetup.rb' + +# Offense count: 3 +# This cop supports safe autocorrection (--autocorrect). +Style/RedundantRegexpArgument: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + +# Offense count: 7 +# This cop supports safe autocorrection (--autocorrect). +Style/RedundantSelf: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + +# Offense count: 19 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle, AllowInnerSlashes. +# SupportedStyles: slashes, percent_r, mixed +Style/RegexpLiteral: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Style/RescueModifier: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + # Offense count: 2 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods, MaxChainLength. @@ -846,12 +1063,13 @@ Style/SafeNavigation: Exclude: - 'lib/beaker-puppet/install_utils/foss_utils.rb' -# Offense count: 3 +# Offense count: 4 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: RequireEnglish, EnforcedStyle. # SupportedStyles: use_perl_names, use_english_names, use_builtin_english_names Style/SpecialGlobalVars: Exclude: + - 'lib/beaker-puppet/inifile.rb' - 'lib/beaker-puppet/install_utils/puppet5.rb' # Offense count: 15 @@ -864,6 +1082,28 @@ Style/StringConcatenation: - 'lib/beaker-puppet/install_utils/foss_utils.rb' - 'spec/beaker-puppet/install_utils/module_utils_spec.rb' +# Offense count: 6 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline. +# SupportedStyles: single_quotes, double_quotes +Style/StringLiterals: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: AllowMethodsWithArguments, AllowedMethods, AllowedPatterns, AllowComments. +# AllowedMethods: define_method +Style/SymbolProc: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + +# Offense count: 8 +# This cop supports safe autocorrection (--autocorrect). +Style/WhenThen: + Exclude: + - 'lib/beaker-puppet/inifile.rb' + # Offense count: 1 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. @@ -879,7 +1119,7 @@ Style/ZeroLengthPredicate: - 'lib/beaker-puppet/helpers/puppet_helpers.rb' - 'lib/beaker-puppet/install_utils/foss_utils.rb' -# Offense count: 122 +# Offense count: 108 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns. # URISchemes: http, https