From 3b4947efa972555fcdc8c83820d2eb25fbb418f5 Mon Sep 17 00:00:00 2001 From: Andrew Dupont Date: Mon, 1 Sep 2025 09:51:36 -0700 Subject: [PATCH 1/5] Update `package-lock.json` --- package-lock.json | 36 +++++++++++++++++++++--------------- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/package-lock.json b/package-lock.json index ae58abd3..7b71d0a6 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,23 +1,24 @@ { - "name": "superstring", + "name": "@pulsar-edit/superstring", "version": "3.0.0", "lockfileVersion": 2, "requires": true, "packages": { "": { - "name": "superstring", + "name": "@pulsar-edit/superstring", "version": "3.0.0", "license": "MIT", - "dependencies": { - "nan": "^2.14.2" - }, "devDependencies": { "chai": "^2.0.0", "mocha": "^2.3.4", + "node-addon-api": "^8.3.1", "random-seed": "^0.2.0", "standard": "^4.5.4", "temp": "^0.8.3", "unzip": "^0.1.11" + }, + "engines": { + "node": ">=16" } }, "node_modules/@isaacs/cliui": { @@ -2502,11 +2503,6 @@ "integrity": "sha512-amvrY4m/7oZamehMoFi1tbwU/kXbVvRTGM2S7F+PZi3n51Jx+9AcSQ3EQsag3tR+hS2higfgOP/Kl8kri/X52A==", "dev": true }, - "node_modules/nan": { - "version": "2.22.0", - "resolved": "https://registry.npmjs.org/nan/-/nan-2.22.0.tgz", - "integrity": "sha512-nbajikzWTMwsW+eSsNm3QwlOs7het9gGJU5dDZzRTQGk03vyBOauxgI4VakDzE0PtsGTmXPsXTbbjVhRwR5mpw==" - }, "node_modules/natives": { "version": "1.1.6", "resolved": "https://registry.npmjs.org/natives/-/natives-1.1.6.tgz", @@ -2520,6 +2516,15 @@ "integrity": "sha512-CXdUiJembsNjuToQvxayPZF9Vqht7hewsvy2sOWafLvi2awflj9mOC6bHIg50orX8IJvWKY9wYQ/zB2kogPslQ==", "dev": true }, + "node_modules/node-addon-api": { + "version": "8.5.0", + "resolved": "https://registry.npmjs.org/node-addon-api/-/node-addon-api-8.5.0.tgz", + "integrity": "sha512-/bRZty2mXUIFY/xU5HLvveNHlswNJej+RnxBjOMkidWfwZzgTbPG1E3K5TOxRLOR+5hX7bSofy8yf1hZevMS8A==", + "dev": true, + "engines": { + "node": "^18 || ^20 || >= 21" + } + }, "node_modules/nopt": { "version": "7.2.1", "resolved": "https://registry.npmjs.org/nopt/-/nopt-7.2.1.tgz", @@ -6086,11 +6091,6 @@ "integrity": "sha512-amvrY4m/7oZamehMoFi1tbwU/kXbVvRTGM2S7F+PZi3n51Jx+9AcSQ3EQsag3tR+hS2higfgOP/Kl8kri/X52A==", "dev": true }, - "nan": { - "version": "2.22.0", - "resolved": "https://registry.npmjs.org/nan/-/nan-2.22.0.tgz", - "integrity": "sha512-nbajikzWTMwsW+eSsNm3QwlOs7het9gGJU5dDZzRTQGk03vyBOauxgI4VakDzE0PtsGTmXPsXTbbjVhRwR5mpw==" - }, "natives": { "version": "1.1.6", "resolved": "https://registry.npmjs.org/natives/-/natives-1.1.6.tgz", @@ -6103,6 +6103,12 @@ "integrity": "sha512-CXdUiJembsNjuToQvxayPZF9Vqht7hewsvy2sOWafLvi2awflj9mOC6bHIg50orX8IJvWKY9wYQ/zB2kogPslQ==", "dev": true }, + "node-addon-api": { + "version": "8.5.0", + "resolved": "https://registry.npmjs.org/node-addon-api/-/node-addon-api-8.5.0.tgz", + "integrity": "sha512-/bRZty2mXUIFY/xU5HLvveNHlswNJej+RnxBjOMkidWfwZzgTbPG1E3K5TOxRLOR+5hX7bSofy8yf1hZevMS8A==", + "dev": true + }, "nopt": { "version": "7.2.1", "resolved": "https://registry.npmjs.org/nopt/-/nopt-7.2.1.tgz", From e76a8d9df0a3c6e86cfdb3b417579b071ee56d2b Mon Sep 17 00:00:00 2001 From: Andrew Dupont Date: Mon, 1 Sep 2025 09:54:52 -0700 Subject: [PATCH 2/5] Update Windows image --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 27d8a6e2..e655d46f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,7 +19,7 @@ jobs: - 18 - 20 include: - - os: windows-2019 + - os: windows-2022 node_version: 14 - os: macos-13 node_version: 14 From c379980e32a5ca98a557b232dc1bc7067ef4a19b Mon Sep 17 00:00:00 2001 From: Andrew Dupont Date: Mon, 1 Sep 2025 09:56:44 -0700 Subject: [PATCH 3/5] Update repo location in `package.json` --- package.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index 87fc1e8f..3ffca0a8 100644 --- a/package.json +++ b/package.json @@ -18,7 +18,7 @@ }, "repository": { "type": "git", - "url": "https://github.com/atom/superstring.git" + "url": "https://github.com/pulsar-edit/superstring.git" }, "keywords": [ "text", @@ -30,13 +30,13 @@ "author": "Nathan Sobo ", "license": "MIT", "bugs": { - "url": "https://github.com/atom/superstring/issues" + "url": "https://github.com/pulsar-edit/superstring/issues" }, - "homepage": "https://github.com/atom/superstring", + "homepage": "https://github.com/pulsar-edit/superstring", "devDependencies": { "chai": "^2.0.0", "mocha": "^2.3.4", - "node-addon-api": "^8.3.1", + "node": "^8.3.1", "random-seed": "^0.2.0", "standard": "^4.5.4", "temp": "^0.8.3", From 17a3f2ff42a5b8d39b129ae1c4fded5acfa2869f Mon Sep 17 00:00:00 2001 From: Andrew Dupont Date: Mon, 1 Sep 2025 10:00:10 -0700 Subject: [PATCH 4/5] Drop Node 14 testing in CI We don't declare support for it and there isn't a GHA Windows image that makes it easy to install Node 14 anymore. --- .github/workflows/ci.yml | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e655d46f..b6ae41b8 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,11 +18,6 @@ jobs: - 16 - 18 - 20 - include: - - os: windows-2022 - node_version: 14 - - os: macos-13 - node_version: 14 name: Node ${{ matrix.node_version }} on ${{ matrix.os }} steps: @@ -41,16 +36,6 @@ jobs: with: node-version: ${{ matrix.node_version }} - - name: Setup python - if: matrix.node_version == 14 - # Old versions of Node bundle old versions of npm. - # Old versions of npm bundle old versions of node-gyp. - # Old versions of node-gyp are incompatible with Python 3.11+. - # Install older Python (Python 3.10) as a workaround. - uses: actions/setup-python@v4 - with: - python-version: '3.10' - - name: Install Python setuptools (Unix-likes) # This is needed for Python 3.12+, since many versions of node-gyp # are incompatible with Python 3.12+, which no-longer ships 'distutils' From df3efca9863c198d26b8203831f1f683c13a18d4 Mon Sep 17 00:00:00 2001 From: Andrew Dupont Date: Mon, 1 Sep 2025 10:06:16 -0700 Subject: [PATCH 5/5] Fix `package.json` mistake --- package-lock.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index 7b71d0a6..02de933f 100644 --- a/package-lock.json +++ b/package-lock.json @@ -11,7 +11,7 @@ "devDependencies": { "chai": "^2.0.0", "mocha": "^2.3.4", - "node-addon-api": "^8.3.1", + "node-addon-api": "^8.5.0", "random-seed": "^0.2.0", "standard": "^4.5.4", "temp": "^0.8.3", diff --git a/package.json b/package.json index 3ffca0a8..8c8c5db8 100644 --- a/package.json +++ b/package.json @@ -36,7 +36,7 @@ "devDependencies": { "chai": "^2.0.0", "mocha": "^2.3.4", - "node": "^8.3.1", + "node-addon-api": "^8.5.0", "random-seed": "^0.2.0", "standard": "^4.5.4", "temp": "^0.8.3",