Skip to content

Commit 2dc55ed

Browse files
authored
Merge pull request #8 from micprog/fix_soc_defines
Remove `CLUSTER_ALIAS` define from the XBAR_PE
2 parents 02a5eae + 441a739 commit 2dc55ed

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

rtl/peripheral_interco/AddressDecoder_PE_Req.sv

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343
////////////////////////////////////////////////////////////////////////////////
4444

4545
`include "parameters.v"
46-
`include "pulp_soc_defines.sv"
4746

4847
module AddressDecoder_PE_Req
4948
#(
@@ -54,6 +53,7 @@ module AddressDecoder_PE_Req
5453
parameter ADDR_WIDTH = 32,
5554
parameter PE_ROUTING_LSB = 16,
5655
parameter PE_ROUTING_MSB = 19,
56+
parameter CLUSTER_ALIAS = 1'b0,
5757
parameter CLUSTER_ALIAS_BASE = 12'h000
5858
)
5959
(
@@ -89,14 +89,9 @@ module AddressDecoder_PE_Req
8989
end
9090

9191

92-
// FIXME -- Not parameteric
9392
always_comb
9493
begin
95-
`ifdef CLUSTER_ALIAS
96-
if( ( data_add_i[31:20] >= PE_START) && ( data_add_i[31:20] < PE_END ) || ( data_add_i[31:20] >= (CLUSTER_ALIAS_BASE+2) ) && ( data_add_i[31:20] < (CLUSTER_ALIAS_BASE+3) ) )
97-
`else
98-
if( ( data_add_i[31:20] >= PE_START ) && ( data_add_i[31:20] < PE_END ) )
99-
`endif
94+
if( ( data_add_i[31:20] >= PE_START ) && ( data_add_i[31:20] < PE_END ) || ( CLUSTER_ALIAS && ( ( data_add_i[31:20] >= (CLUSTER_ALIAS_BASE+2) ) && ( data_add_i[31:20] < (CLUSTER_ALIAS_BASE+3) ) ) ) )
10095
ROUTING_ADDR = data_add_i[PE_ROUTING_MSB:PE_ROUTING_LSB];
10196
else
10297
ROUTING_ADDR = '1;

rtl/peripheral_interco/ResponseBlock_PE.sv

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ module ResponseBlock_PE
5757
parameter ADDR_WIDTH = 32,
5858
parameter PE_ROUTING_LSB = 16,
5959
parameter PE_ROUTING_MSB = 19,
60+
parameter CLUSTER_ALIAS = 1'b0,
6061
parameter CLUSTER_ALIAS_BASE = 12'h000
6162
)
6263
(
@@ -168,6 +169,7 @@ module ResponseBlock_PE
168169
.ADDR_WIDTH ( ADDR_WIDTH ),
169170
.PE_ROUTING_LSB ( PE_ROUTING_LSB ),
170171
.PE_ROUTING_MSB ( PE_ROUTING_MSB ),
172+
.CLUSTER_ALIAS ( CLUSTER_ALIAS ),
171173
.CLUSTER_ALIAS_BASE (CLUSTER_ALIAS_BASE)
172174
)
173175
i_AddressDecoder_PE_Req

rtl/peripheral_interco/XBAR_PE.sv

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ module XBAR_PE
6262
parameter PE_ROUTING_LSB = 10,
6363
parameter PE_ROUTING_MSB = PE_ROUTING_LSB+$clog2(N_SLAVE)-1,
6464

65+
parameter CLUSTER_ALIAS = 1'b0,
6566
parameter CLUSTER_ALIAS_BASE = 12'h000,
6667

6768
parameter ADDR_PE_WIDTH = PE_MSB - PE_LSB + 1
@@ -273,6 +274,7 @@ module XBAR_PE
273274
.ADDR_WIDTH ( ADDR_WIDTH ),
274275
.PE_ROUTING_LSB ( PE_ROUTING_LSB ),
275276
.PE_ROUTING_MSB ( PE_ROUTING_MSB ),
277+
.CLUSTER_ALIAS ( CLUSTER_ALIAS ),
276278
.CLUSTER_ALIAS_BASE (CLUSTER_ALIAS_BASE)
277279
)
278280
i_ResponseBlock_PE

0 commit comments

Comments
 (0)