Skip to content

Clarifying + one potential change on curator types #22

@0xTranqui

Description

@0xTranqui

@iainnash doing some digging into why we cant figure out how to pass in initialListings upon factory deploy and stumbled upon a question about the curation types. for context these are the types (found in curator.sol):

uint16 public constant CURATION_TYPE_GENERIC = 0;
uint16 public constant CURATION_TYPE_NFT_CONTRACT = 1;
uint16 public constant CURATION_TYPE_CURATION_CONTRACT = 2;
uint16 public constant CURATION_TYPE_CONTRACT = 3;
uint16 public constant CURATION_TYPE_NFT_ITEM = 4;
uint16 public constant CURATION_TYPE_EOA_WALLET = 5;

Two things

  • can you clarify the difference between 0 - type generic, and 3 - type contract? is 3 supposed to specifically mean that its a non 1,2,4,5 contract, while 0 is purposely undefined?
  • what do you think of changing EOA Wallet to EOA/Smart Contract Wallet? feel like smart contract wallets (ex: gnosis) will become more prevalent and we'll want a way to specify them. guess it could be a type 6? but wary of having too many types

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions