curator.sol updateRenderer calling initializeWithData rather than setBaseURI?

[0xTranqui]

@iainnash have ran into some issues with gas limit errors trying to call the updateRenderer function from a UI. I believe the issue is that updateRenderer in curator.sol calls _updateRenderer, which itself calls intitalizeWithData from DefaultMetadataRenderer.sol RATHER than setBaseURI.

My understanding is that the intialize should get called by the constructor, but updates to it should call setBaseURI instead of initialize. Could be wrong but just throwing out there

[iainnash]

This follows the pattern of @ourzora/nft-drops-contracts where the setBaseURI function is called directly on the renderer contract and a new renderer can be optionally initialized when setting the new renderer using an initializing string.

This function matches the same pattern we use. We could change that pattern to use permissioned forwarding to call any method on the renderer but i think it works decently well for drops and having a similar method to update / manage renderers may be ideal.

[0xTranqui]

ok got it. wasn't sure if it was different on this. will defer to u hear since clearly its working great on the drops stuff

[iainnash]

Either way works, but i feel like consistency may be good here.