Replies: 1 comment 2 replies
-
|
First off, thanks for opening this issue! I've gone ahead and moved it to a discussion as it seems it's a better fit. That way we can also make new issues based on where this discussion goes.
Thanks again for this feedback. I'm ok with breaking each of these tasks into their own issue and we can address them 1 by 1. Note I'm also prepping for a |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hey,
the coverletter template contains some things that are bugging me, so I created this issue to discuss them:
Why is each paragraphs in the coverletter supposed to be formatted individually via
coverletter-content()? Why not write the text into the document directly, and useset par(spacing: ...)to space individual paragraphs?modern-cv/lib.typ
Lines 970 to 978 in ec301aa
What's the point of this linebreak?
modern-cv/lib.typ
Lines 910 to 915 in ec301aa
Why is the signature bottom aligned? IMO it should just follow the content of the letter immediately.
modern-cv/lib.typ
Lines 687 to 703 in ec301aa
The vertical spacing seems a bit inconsistent and excessive to me, but that could just be my personal taste. IMO, the margin between paragraphs in the text should be the same as the margin between heading and content, and between content and closing of the letter. But I guess some people have other opinions, so maybe it should be made configurable? When not using
coverletter-content(), the user can just configure the spacing by themself, i.e.#set par(spacing: 2.5em). This way, only the heading and closing margins would need to be configurable.I could create a PR for this, but I wanted to hear your (@ptsouchlos) opinion first. To anyone else reading this, feel free to post your opinion as well. Thanks!
Beta Was this translation helpful? Give feedback.
All reactions