Coverletter template suggestions

[jkhsjdhjs]

Hey,

the coverletter template contains some things that are bugging me, so I created this issue to discuss them:

1. Why is each paragraphs in the coverletter supposed to be formatted individually via coverletter-content()? Why not write the text into the document directly, and use set par(spacing: ...) to space individual paragraphs?
   

   modern-cv/lib.typ

   Lines 970 to 978 in ec301aa

   	/// Cover letter content paragraph. This is the main content of the cover letter.
   	/// - content (content): The content of the cover letter
   	#let coverletter-content(content) = {
   	pad(top: 1em, bottom: 1em)[
   	#set par(first-line-indent: 3em)
   	#set text(weight: "light")
   	#content
   	]
   	}

2. What's the point of this linebreak?
   

   modern-cv/lib.typ

   Lines 910 to 915 in ec301aa

   	// actual content
   	letter-heading
   	body
   	linebreak()
   	signature
   	closing

3. Why is the signature bottom aligned? IMO it should just follow the content of the letter immediately.
   

   modern-cv/lib.typ

   Lines 687 to 703 in ec301aa

   	/// Default signature for the cover letter template.
   	/// - lang-data (dictionary): Structure that contains all the language data. Used with `linguify`
   	/// - language (string): The language of the cover letter.
   	/// - author (string): The author of the cover letter.
   	#let default-signature(lang-data, language, author) = {
   	align(bottom)[
   	#pad(bottom: 2em)[
   	#text(weight: "light")[#linguify("sincerely", from: lang-data)#if (
   	language != "de"
   	) [#sym.comma]] \
   	#if ("signature" in author) {
   	author.signature
   	}
   	#text(weight: "bold")[#author.firstname #author.lastname]
   	]
   	]
   	}

4. The vertical spacing seems a bit inconsistent and excessive to me, but that could just be my personal taste. IMO, the margin between paragraphs in the text should be the same as the margin between heading and content, and between content and closing of the letter. But I guess some people have other opinions, so maybe it should be made configurable? When not using coverletter-content(), the user can just configure the spacing by themself, i.e. #set par(spacing: 2.5em). This way, only the heading and closing margins would need to be configurable.

I could create a PR for this, but I wanted to hear your (@ptsouchlos) opinion first. To anyone else reading this, feel free to post your opinion as well. Thanks!

[ptsouchlos]

First off, thanks for opening this issue! I've gone ahead and moved it to a discussion as it seems it's a better fit. That way we can also make new issues based on where this discussion goes.

1. I like this idea and I think it would make the template easier to use. Thanks for the suggestion!
2. Probably a spacing issue I was trying to solve? I'm not 100% sure what my original intentions were.
3. I could see this going either way honestly. Maybe it would be good to also make this configurable.
4. I could see an argument for making the spacing consistent by default with the option for configuring manually as well.

Thanks again for this feedback. I'm ok with breaking each of these tasks into their own issue and we can address them 1 by 1.

Note I'm also prepping for a 0.10.0 release so at some point in the near future their will be a feature/fix freeze for the release.

[jkhsjdhjs]

I just opened #176 to address these issues. So we should be able to get these resolved before the feature freeze :D

[ptsouchlos]

Awesome! Thanks so much for all your help :)