What is supported from popouts?

[Eryx5502]

Hey! It's been a while since I was forced to move out of linux at work, and I'm excited to be able to take back tmux experience thanks to this project... Thanks for that! :)

Now, In my tmux config I used to have a popup for lazygit:

bind -r g popup -E -w 95% -h 95% -d "#{pane_current_path}" lazygit

I think there are a few things not working as I expected, but not sure if I am trying something unsupported by psmux so I'm asking here in Q&A. Let me know if I should make this into an issue instead.

1. First, although the height with percentage seems to work, width doesn't. It works if I write absolute numbers but not with percentages.
2. -d is causing an error. Is there another way to make the popup to run in the current pane path?
3. If i remove all the parameters and instead do psmux popup lazygit, I do get a lazygit popup. However, no colors are displayed. I guess it could be a TERM issue (or that is what I would have guessed on tmux), but I'm not sure to be honest.

Thanks in advance for any help!

[psmux]

Hey @Eryx5502, welcome to psmux and thanks for the kind words! Really glad it is bringing back that tmux experience for you on Windows.

All three of these are confirmed bugs on our side, and they are all fixed now in commit 0e1dbba. Here is what was going on and what changed:

1. Width percentage not working

You were right. When you passed -w 95%, psmux was just stripping the % and treating the number as absolute columns. So 95% became a 95 column popup instead of 95% of your terminal width. The reason -h 95% seemed to work is that 95 rows happens to fill most terminals vertically by coincidence. Now there is a proper parse_popup_dim function that calculates the actual percentage of terminal dimensions. Both -w 95% and -h 95% will give you a popup that fills 95% of your terminal in each direction.

2. The -d flag

This was completely unhandled. What was happening is the -d flag got skipped, but its argument (#{pane_current_path}) leaked into the command string. So psmux was trying to run #{pane_current_path} lazygit as one command, which naturally failed. Now -d (and -c as an alias, for cross compatibility) is properly parsed as the popup working directory and #{pane_current_path} gets expanded through the format engine. Your original config line should work as is:

bind -r g popup -E -w 95% -h 95% -d "#{pane_current_path}" lazygit

3. No colors in lazygit

Your instinct about TERM was spot on. Regular panes were getting TERM=xterm-256color and COLORTERM=truecolor set explicitly, but popup PTYs were missing this entirely. Programs like lazygit check those variables to decide whether to enable color output. Fixed now, popups get the same environment setup as regular panes, including any default-terminal config you may have set.

You can grab the latest build from master. Let me know if everything works on your end or if anything else comes up!

[psmux]

@Eryx5502 I had to run this multiple times and multiple responses got posted. sorry if it flooded your notifications/emails. Use the latest commit
Hope it works for you now.

[Eryx5502]

No worries! Thanks for the follow up! I saw there's a new release with this changes so I'll give it a try as soon as possible :)

[psmux]

Sure @Eryx5502 , would love to have your feedback

[Eryx5502]

Could test it and works perfectly right now. Thanks for taking the time for implementing this!

[psmux]

Happy to hear that it works. Please share the good news about Psmux with your colleagues and friends. Thank you!