Skip to content

[Question][Hw2] Got some tests wrong when using Int32 library for arithmetic operations #164

@tncks0121

Description

@tncks0121

Name: 박수찬

YOUR QUESTION

I got 77/77 tests correct when I used Int to do integer arithmetic operations, while I got 76/77 tests correct when I used Int32 instead.

In my repository, master branch got all tests correct, and int32 branch got 76/77 tests correct. The difference between these branches is a single commit in the int32 branch that does operations with Int32 library.

I'm wondering if there is a test causing int32 overflow in the hidden tests. Also, given that signed integer overflow in C is undefined behavior, should I raise Invalid_argument if integer overflow happens?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions