[Question][Hw4] Wrong definition of Memory operations

[yusungsim]

It seems bit late, but while I'm still struggling to debug my hw4, I think the given definitions for Memory operators should be changed.

  module Memory (Value: NUMERICAL_DOMAIN) : 

  .....

  (* let join m1 m2 =
     let f = fun x v ->
       try (Value.join v (M.find x m2)) with Not_found -> v in
     M.mapi f m1 *)

   let join m1 m2 =
     let f = fun x v1 v2 -> Some (Value.join v1 v2) in
     M.union f m1 m2

   (*let widen m1 m2 =
     let f = fun x v ->
       try (Value.widen v (M.find x m2)) with Not_found -> v in
     M.mapi f m1*)

   let widen m1 m2 =
     let f = fun x v1 v2 -> Some (Value.widen v1 v2) in
     M.union f m1 m2

   (* let narrow m1 m2 =
     let f = fun x v ->
       try (Value.narrow v (M.find x m2)) with Not_found -> v in
     M.mapi f m1 *)

   let narrow m1 m2 =
     let f = fun x v1 v2 -> Some (Value.narrow v1 v2) in
     M.union f m1 m2

Commented out ones are the ones that given in the template, and non-commented ones are the ones that I changed.
Because domain of m1 and m2 (ie. set of keys == labels) can be different, so I think Map.union should be used.

[kangwoosukeq]

There is no definition for those Memory operators in our template, so it's up to you. Check your initial commit.