From 3d1faf8fbb7329cf46294701bdfd8a42a73e7207 Mon Sep 17 00:00:00 2001 From: Linnea Kirby Date: Fri, 29 Jan 2021 17:01:50 -0500 Subject: [PATCH] Fix Procfile, update documentation. Fix Procfile: - Before this change, the Procfile only defines the server - After this change, the Procfile runs the server. Update documentation: - Before this change, OAUTH_CLIENT_{ID,SECRET} are mentioned in the README, but the application actually uses GITHUB_APPLICATION_CLIENT_{ID,SECRET}. --- Procfile | 2 +- README.md | 13 ++++++++----- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/Procfile b/Procfile index 489b270..1da0cd6 100644 --- a/Procfile +++ b/Procfile @@ -1 +1 @@ -web: node server.js +web: node index.js diff --git a/README.md b/README.md index 415c6e7..85525fe 100644 --- a/README.md +++ b/README.md @@ -95,17 +95,20 @@ Use the button below to instantly setup your own Gatekeeper instance on Heroku. heroku apps:create APP_NAME ``` -3. Provide OAUTH_CLIENT_ID and OAUTH_CLIENT_SECRET: +3. Provide GITHUB_APPLICATION_CLIENT_ID and GITHUB_APPLICATION_CLIENT_SECRET: ``` - heroku config:set OAUTH_CLIENT_ID=XXXX OAUTH_CLIENT_SECRET=YYYY + heroku config:set GITHUB_APPLICATION_CLIENT_ID=XXXX GITHUB_APPLICATION_CLIENT_SECRET=YYYY ``` 4. Push changes to heroku +Note: heroku expects `master` or `main` branches -- you can't push from the default `devlopment` branch. If your repo doesn't have a master already, run `git co -b master`. + ``` git push heroku master ``` + OR ``` @@ -128,11 +131,11 @@ Use the button below to instantly setup your own Gatekeeper instance on Azure. azure site create SITE_NAME --git ``` -2. Provide OAUTH_CLIENT_ID and OAUTH_CLIENT_SECRET: +2. Provide GITHUB_APPLICATION_CLIENT_ID and GITHUB_APPLICATION_CLIENT_SECRET: ``` - azure site appsetting add OAUTH_CLIENT_ID=XXXX - azure site appsetting add OAUTH_CLIENT_SECRET=YYYY + azure site appsetting add GITHUB_APPLICATION_CLIENT_ID=XXXX + azure site appsetting add GITHUB_APPLICATION_CLIENT_SECRET=YYYY ``` 3. Push changes to Azure