From cdf3e32f2ff53f708b9934d0d34d50f1d7f05c48 Mon Sep 17 00:00:00 2001 From: Serge Hallyn Date: Mon, 17 Nov 2025 19:54:54 -0600 Subject: [PATCH 1/3] fix: nightly action: follow actionlint comments Move nightly.yml to .github/workflows, in the hopes that makes it show up. Add workflow_call to the build.yaml triggers, else nightly.yaml can't call it. Have build.yaml inherit all secrets from nightly.yaml. actionlint had a warning about the previous version. Signed-off-by: Serge Hallyn --- .github/workflows/build.yaml | 1 + .github/{ => workflows}/nightly.yaml | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) rename .github/{ => workflows}/nightly.yaml (68%) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 3fc28d2..1e5bef8 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -1,6 +1,7 @@ on: push: pull_request: + workflow_call: name: build jobs: build: diff --git a/.github/nightly.yaml b/.github/workflows/nightly.yaml similarity index 68% rename from .github/nightly.yaml rename to .github/workflows/nightly.yaml index 26821f6..f8e6c1a 100644 --- a/.github/nightly.yaml +++ b/.github/workflows/nightly.yaml @@ -8,5 +8,4 @@ on: jobs: build: uses: ./.github/workflows/build.yaml - secrets: - codecov_token: ${{ secrets.CODECOV_TOKEN }} + secrets: inherit From 7bcc3abd542584be7c2ec8b0c224cfb079bcd015 Mon Sep 17 00:00:00 2001 From: Serge Hallyn Date: Mon, 17 Nov 2025 20:06:08 -0600 Subject: [PATCH 2/3] fix: fix some more actionlint errors update some dependencies, and escape $HOME Signed-off-by: Serge Hallyn --- .github/workflows/build.yaml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 1e5bef8..a054e95 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -11,11 +11,11 @@ jobs: name: build runs-on: ${{ matrix.os }} steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v5 - name: Set up golang - uses: actions/setup-go@v2 + uses: actions/setup-go@v6 with: - go-version: 1.21 + go-version: 1.24 - name: install dependencies run: | sudo apt-get update @@ -24,7 +24,7 @@ jobs: squashfuse squashfs-tools erofs-utils - name: setup lxc run: | - chmod ugo+x $HOME + chmod ugo+x "$HOME" cat /etc/subuid /etc/subgid u=$(id -un) && g=$(id -gn) echo "u=$u g=$g" @@ -74,7 +74,7 @@ jobs: files: ./unit-coverage.txt,./integ-coverage.txt token: ${{ secrets.CODECOV_TOKEN }} # required - name: Release - uses: softprops/action-gh-release@v1 + uses: softprops/action-gh-release@v2 if: startsWith(github.ref, 'refs/tags/') with: files: | From c500671fcd074eefd270a61d29c3a4d0e732d573 Mon Sep 17 00:00:00 2001 From: Serge Hallyn Date: Mon, 17 Nov 2025 20:47:44 -0600 Subject: [PATCH 3/3] chore: update checkout to v5 everywhere Signed-off-by: Serge Hallyn --- .github/workflows/codeql-analysis.yml | 2 +- .github/workflows/commit-msg.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml index abc3ea9..dc2a41f 100644 --- a/.github/workflows/codeql-analysis.yml +++ b/.github/workflows/codeql-analysis.yml @@ -43,7 +43,7 @@ jobs: steps: - name: Checkout repository - uses: actions/checkout@v3 + uses: actions/checkout@v5 - name: Install go uses: actions/setup-go@v5 diff --git a/.github/workflows/commit-msg.yaml b/.github/workflows/commit-msg.yaml index ab25fcf..4bb46e8 100644 --- a/.github/workflows/commit-msg.yaml +++ b/.github/workflows/commit-msg.yaml @@ -16,7 +16,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v3 + uses: actions/checkout@v5 - name: Check Commit Type uses: gsactions/commit-message-checker@v2 with: