/all function throws an error

[hvdklauw]

It actually outputs it to me:

File "keychain/app.py", line 115, in all_keys
keys_ = [lookup_key(email, key) for key in keys[email]]
NameError: global name 'keys' is not defined

[sysr-q]

Confirmed, I get the same output:

% curl -s ssh.keychain.io/$email/all                           22:24:52
Traceback (most recent call last):
  File "/app/.heroku/python/lib/python2.7/site-packages/eventlet/wsgi.py", line 382, in handle_one_response
    result = self.application(self.environ, start_response)
  File "/app/.heroku/python/lib/python2.7/site-packages/flask/app.py", line 1701, in __call__
    return self.wsgi_app(environ, start_response)
  File "/app/.heroku/python/lib/python2.7/site-packages/flask/app.py", line 1689, in wsgi_app
    response = self.make_response(self.handle_exception(e))
  File "/app/.heroku/python/lib/python2.7/site-packages/flask/app.py", line 1687, in wsgi_app
    response = self.full_dispatch_request()
  File "/app/.heroku/python/lib/python2.7/site-packages/flask/app.py", line 1360, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/app/.heroku/python/lib/python2.7/site-packages/flask/app.py", line 1358, in full_dispatch_request
    rv = self.dispatch_request()
  File "/app/.heroku/python/lib/python2.7/site-packages/flask/app.py", line 1344, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "keychain/app.py", line 115, in all_keys
    keys_ = [lookup_key(email, key) for key in keys[email]]
NameError: global name 'keys' is not defined

[RyanBalfanz]

I just hit this too:

$ curl -s ssh.keychain.io/<email>/all
Traceback (most recent call last):
  File "/app/.heroku/python/lib/python2.7/site-packages/eventlet/wsgi.py", line 382, in handle_one_response
    result = self.application(self.environ, start_response)
  File "/app/.heroku/python/lib/python2.7/site-packages/flask/app.py", line 1701, in __call__
    return self.wsgi_app(environ, start_response)
  File "/app/.heroku/python/lib/python2.7/site-packages/flask/app.py", line 1689, in wsgi_app
    response = self.make_response(self.handle_exception(e))
  File "/app/.heroku/python/lib/python2.7/site-packages/flask/app.py", line 1687, in wsgi_app
    response = self.full_dispatch_request()
  File "/app/.heroku/python/lib/python2.7/site-packages/flask/app.py", line 1360, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/app/.heroku/python/lib/python2.7/site-packages/flask/app.py", line 1358, in full_dispatch_request
    rv = self.dispatch_request()
  File "/app/.heroku/python/lib/python2.7/site-packages/flask/app.py", line 1344, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "keychain/app.py", line 115, in all_keys
    keys_ = [lookup_key(email, key) for key in keys[email]]
NameError: global name 'keys' is not defined

[progrium]

Probably a simple fix. I'm sure any of you could go for it.

On Tue, Jan 28, 2014 at 12:14 PM, Ryan Balfanz notifications@github.comwrote:

I just hit this too:

$ curl -s ssh.keychain.io//all
Traceback (most recent call last):
File "/app/.heroku/python/lib/python2.7/site-packages/eventlet/wsgi.py", line 382, in handle_one_response

result = self.application(self.environ, start_response)
File "/app/.heroku/python/lib/python2.7/site-packages/flask/app.py", line 1701, in call
return self.wsgi_app(environ, start_response)
File "/app/.heroku/python/lib/python2.7/site-packages/flask/app.py", line 1689, in wsgi_app
response = self.make_response(self.handle_exception(e))
File "/app/.heroku/python/lib/python2.7/site-packages/flask/app.py", line 1687, in wsgi_app
response = self.full_dispatch_request()
File "/app/.heroku/python/lib/python2.7/site-packages/flask/app.py", line 1360, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/app/.heroku/python/lib/python2.7/site-packages/flask/app.py", line 1358, in full_dispatch_request
rv = self.dispatch_request()
File "/app/.heroku/python/lib/python2.7/site-packages/flask/app.py", line 1344, in dispatch_request
return self.view_functionsrule.endpoint

File "keychain/app.py", line 115, in all_keys
keys_ = [lookup_key(email, key) for key in keys[email]]
NameError: global name 'keys' is not defined

Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-33506759
.

Jeff Lindsay
http://progrium.com

[RyanBalfanz]

@progrium, I'm unable to reproduce locally. Perhaps keychain.io isn't running the latest version?

Steps to try to reproduce:

• Fork
• Create a new S3 bucket in my AWS account
• Add my AWS and SendGrid credentials to .env
• foreman start
• curl -s http://127.0.0.1:5000/rbalfanz@gmail.com/upload | bash
• Wait for email, click confirmation link -> "Action completed"
• curl -s http://127.0.0.1:5000/rbalfanz@gmail.com/all -> spits out my key as expected

[cinaglia]

The fix (cinaglia@a1725cf) for this issue has been merged in a0f7017. I'm guessing it has never been pushed to production, though.