From b3f785838e52bca69dd0c61f8eca045b86ca7253 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Mon, 3 Oct 2022 05:11:15 +0000 Subject: [PATCH 1/2] Adding tarfile member sanitization to extractall() --- .../semseg/pisa/Dataloading/PascalDataset.py | 21 ++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/models/semseg/pisa/Dataloading/PascalDataset.py b/models/semseg/pisa/Dataloading/PascalDataset.py index 4669991..c2f5513 100644 --- a/models/semseg/pisa/Dataloading/PascalDataset.py +++ b/models/semseg/pisa/Dataloading/PascalDataset.py @@ -95,7 +95,26 @@ def extract_berkeley_dataset_if_not_extracted(data_path, tar_f="benchmark.tgz", def _extract_tar(tar_path, data_path): with tarfile.open(tar_path) as tf: - tf.extractall(path=data_path) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner) + + + safe_extract(tf, path=data_path) # Prepare def _prepare_dataset(data_path): From 2d4faa8bbe4eef98331a30b958fd68b08a9cc17d Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Tue, 4 Oct 2022 23:36:24 +0000 Subject: [PATCH 2/2] Adding numeric_owner as keyword arguement --- models/semseg/pisa/Dataloading/PascalDataset.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/models/semseg/pisa/Dataloading/PascalDataset.py b/models/semseg/pisa/Dataloading/PascalDataset.py index c2f5513..ebdc709 100644 --- a/models/semseg/pisa/Dataloading/PascalDataset.py +++ b/models/semseg/pisa/Dataloading/PascalDataset.py @@ -111,7 +111,7 @@ def safe_extract(tar, path=".", members=None, *, numeric_owner=False): if not is_within_directory(path, member_path): raise Exception("Attempted Path Traversal in Tar File") - tar.extractall(path, members, numeric_owner) + tar.extractall(path, members, numeric_owner=numeric_owner) safe_extract(tf, path=data_path)