diff --git a/models/semseg/pisa/Dataloading/PascalDataset.py b/models/semseg/pisa/Dataloading/PascalDataset.py index 4669991..ebdc709 100644 --- a/models/semseg/pisa/Dataloading/PascalDataset.py +++ b/models/semseg/pisa/Dataloading/PascalDataset.py @@ -95,7 +95,26 @@ def extract_berkeley_dataset_if_not_extracted(data_path, tar_f="benchmark.tgz", def _extract_tar(tar_path, data_path): with tarfile.open(tar_path) as tf: - tf.extractall(path=data_path) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tf, path=data_path) # Prepare def _prepare_dataset(data_path):