Merge pull request #34 from prilk-consulting/feat/matching-dialog-in-parser

pritambiswal · web-flow · commit 37484065c917 · 2026-02-05T04:03:35.000+05:30
fix: make purchase order non-mandatory in matching dialog
diff --git a/apt_packages.txt b/apt_packages.txt
@@ -0,0 +1,2 @@
+libxml2-dev
+libxslt-dev
diff --git a/edocument/edocument/doctype/edocument/edocument.js b/edocument/edocument/doctype/edocument/edocument.js
@@ -135,6 +135,7 @@ function show_matching_dialog(frm, matching_data, config) {
 function save_matching(frm, dialog, original_data) {
 	const data = JSON.parse(JSON.stringify(original_data));
 	const values = dialog.get_values();
+	if (!values) return; // Validation failed
 
 	// Update supplier
 	if (data.supplier) {
diff --git a/edocument/edocument/profiles/peppol/matcher.py b/edocument/edocument/profiles/peppol/matcher.py
@@ -530,7 +530,6 @@ def _get_dialog_config(matching_data: dict) -> dict:
 				"fieldname": "purchase_order",
 				"label": _("Match to Purchase Order"),
 				"options": "Purchase Order",
-				"reqd": 1,
 				"default": po_data.get("matched"),
 			}
 		)

Original file line number	Diff line number	Diff line change
`@@ -530,7 +530,6 @@ def _get_dialog_config(matching_data: dict) -> dict:`
`530`	`530`	`"fieldname": "purchase_order",`
`531`	`531`	`"label": _("Match to Purchase Order"),`
`532`	`532`	`"options": "Purchase Order",`
`533`		`- "reqd": 1,`
`534`	`533`	`"default": po_data.get("matched"),`
`535`	`534`	`}`
`536`	`535`	`)`