Wrong comment about AI logic for evolution cards (or bug in AI logic)

[oatspear]

poketcg/src/engine/duel/ai/hand_pokemon.asm

Line 246 in d5f3b33

; if defending Pokémon can KO evolution, lower AI score

In the code block below the referenced comment, the AI calls CheckIfDefendingPokemonCanKnockOut and lowers the score to play the evolution card if this function sets carry - i.e., if the Defending Pokémon can score a Knock Out. However, the comment says "can KO evolution", and this is partially wrong because, while the play area card is temporarily swapped with the evolution for evaluation of attacks, the duel variable for HP is not swapped. Thus, CheckIfDefendingPokemonCanKnockOut checks a KO against the pre-evolution HP, while using the evolution card data for the rest of the damage calculation (Weakness, Resistance, Powers).

So, the intent of this block was good (do not waste an evolution card if it is going to be knocked out), but the implementation seems to be flawed. The AI will lower evolution score if the Basic Pokémon is at risk of being knocked out, even though the evolution might survive it (larger HP pool).

[ElectroDeoxys]

I interpret this as a bug because if the second interpretation was correct, I would expect a second KO check on the evolution card right afterwards (functionally it would be a waste to evolve the Pokémon if it's KO'd anyway). Of course I could be wrong here, but I think Occam's Razor cuts in favour of the interpretation that they just forgot that HP/Weakness/Resistance wasn't updated for the damage calculation to work (in fact at the time that was the assumption I did when documenting this part).

If everyone is okay with that we can write a bug comment and document it in bugs_and_glitches.md.