Saving history to a file, persisting it across invocations

[aramrw]

I built it on windows and there is no history of things you typed in, its the only thing im missing from things like nushell and powershell etc

specifically like I mean if you type cargo run with certain args it can persist even if you close the shell and show up as a placeholder like this:

[certik]

I see, yes, saving the history to a file and loading it on the next start.

I use it on my macOS also, and it seems to preserve history. So it's some bug we need to fix.

Btw, here is my list of the missing features on Windows specifically: #35, I've been using it daily for about half a year now on Windows, it's very solid.

[aramrw]

any news on this? if its not high priority maybe u could tell me where its supposed to be at and I can try to fix it on windows

[certik]

I just checked on Windows and it has history for me: I open a new terminal with shell and hit "up arrow" and it shows the history. Can you first confirm that this basic history works for you as well?

Then the other part of the issue you reported is to offer "tab completion" based on history? That is not implemented yet. If you want to implement it, that would be awesome.

[aramrw]

WindowsTerminal_PcHKmK9P8h.mp4

It has history for me as well, but not when I close the terminal. It's weird because obviously there is some history as when I deleted it cargo run still shows up so its saved somewhere but I guess it just stopped doing it

is there a certain branch I should build instead?

[aramrw]

wrong issue

[certik]

The history is saved into ~/.shell_history.

Can you exactly document the steps of the bug that you are reporting, so that it can be reproduced?

[aramrw]

The history is saved into ~/.shell_history.

Can you exactly document the steps of the bug that you are reporting, so that it can be reproduced?

1. type in a command, maybe cargo run -- --fake_flag.
2. restart your terminal and press up arrow on the keyboard

the last entered command isn't there. as you can see in the video, after I run clear, I press the up arrow twice, it shows my last command, its the long cargo one with lots of arguments, but that's the same session.

However I then kill the terminal, and press up again, you can see it only shows cargo run, then ls.

i thought maybe its because of neovim, so I tried it in my regular windows terminal, and nope, it doesn't remember it either.

I typed another cargo command into my raw terminal (no neovim), press enter. Kill my terminal, press up, and it's still just cargo run->cargo->cd->ls, no more history after that.

this is my .shell_history, it doesn't get updated for some reason:

#V2
ls
cd
cargo
cargo run

So i'm guessing the "local" history of the terminal gets saved in memory right? that's why after I kill it, it doesn't remember.

Im just confused because obviously this worked at some point then stopped, because I do have things inside my .shell_history

[certik]

When you say "restart the terminal", do you exit the terminal cleanly (Ctrl-D), or do you kill it (for example by closing the terminal window directly)?

Try exiting it by pressing Ctrl-D and check if this fixes the problem. I tested Ctrl-D on Windows and it works for me.

[aramrw]

thanks that fixed 👍🏼 it saves now, however it might be a good idea to either catch the unwind n write to the file or just write it after each command

I'm still a little confused because I've never used ctrl-D in my life to exit the terminal 🤔 and I had commands in there before