fix(chart): remove kustomize-adopt hook that fails on tainted clusters#34
Merged
ian-flores merged 1 commit intomainfrom Jan 13, 2026
Merged
fix(chart): remove kustomize-adopt hook that fails on tainted clusters#34ian-flores merged 1 commit intomainfrom
ian-flores merged 1 commit intomainfrom
Conversation
Remove the pre-install/pre-upgrade hook Job that adopts kustomize-managed resources into Helm. This hook cannot be scheduled on clusters with taints (e.g., workload-type=session:NoSchedule, nvidia.com/gpu=true:NoSchedule). PTD has its own migration job that handles CRD adoption, making this hook redundant. Removed resources: - Job: kustomize-adopt - ServiceAccount: cleanup - ClusterRole: cleanup - ClusterRoleBinding: cleanup
|
Claude finished @ian-flores's task —— View job PR Review Complete
Reviewed as a non-blocking comment. The PR cleanly removes redundant migration functionality that was causing scheduling failures on tainted clusters. No issues found. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
LGTM - This is a clean removal of redundant functionality that was causing scheduling failures.
Helm Chart Checklist
- Chart version bump appropriate (patch version for removing unused feature)
- No orphaned references to removed resources
- RBAC removal reduces attack surface (removed ServiceAccount, ClusterRole, ClusterRoleBinding)
- Migration directory cleaned up (was the only file in it)
Security (Elevated Scrutiny - RBAC Changes)
The removal of the {{ .Release.Name }}-cleanup ClusterRole is a security improvement:
- Removed broad
get,list,patchpermissions on CRDs, Deployments, RBAC resources - These permissions were only needed for the migration job which is no longer required
Notes
- The hook's purpose (adopting kustomize-managed resources into Helm) is now handled by PTD's migration job
- The scheduling issue on tainted clusters (
NoScheduletaints) is resolved by removing the Job entirely - No documentation references to kustomize migration found that would need updating
Ship it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kustomize-adoptHelm hook Job that runs on pre-install/pre-upgradeworkload-type=session:NoSchedule,nvidia.com/gpu=true:NoSchedule)Removed Resources
{{ .Release.Name }}-kustomize-adopt{{ .Release.Name }}-cleanup{{ .Release.Name }}-cleanup{{ .Release.Name }}-cleanupChart Version
Bumped from 1.0.3 → 1.0.4
Test Plan
helm lintpasseshelm templaterenders successfully