Skip to content

Commit fd0b137

Browse files
committed
Tweaks
1 parent d67458c commit fd0b137

File tree

1 file changed

+9
-13
lines changed

1 file changed

+9
-13
lines changed

rsconnect/bundle.py

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1650,7 +1650,7 @@ def _warn_on_missing_python_version(version_constraint: Optional[str]) -> None:
16501650
"""
16511651
if version_constraint is None:
16521652
click.secho(
1653-
" Warning: Python version constraint missing from pyproject.toml or .python-version\n"
1653+
" Warning: Python version constraint missing from pyproject.toml, setup.cfg or .python-version\n"
16541654
" Connect will guess the version to use based on local environment.\n"
16551655
" Consider specifying a Python version constraint.",
16561656
fg="yellow",
@@ -1734,9 +1734,7 @@ def inspect_environment(
17341734
def _get_python_env_info(
17351735
file_name: str,
17361736
python: str | None,
1737-
force_generate: bool = False,
1738-
override_python_version: str | None = None,
1739-
python_version_requirement: str | None = None,
1737+
force_generate: bool = False
17401738
) -> tuple[str, Environment]:
17411739
"""
17421740
Gathers the python and environment information relating to the specified file
@@ -1756,13 +1754,6 @@ def _get_python_env_info(
17561754
raise RSConnectException(environment.error)
17571755
logger.debug("Python: %s" % python)
17581756
logger.debug("Environment: %s" % pformat(environment._asdict()))
1759-
1760-
if python_version_requirement:
1761-
environment.python_version_requirement = python_version_requirement
1762-
1763-
if override_python_version:
1764-
environment.python = override_python_version
1765-
17661757
return python, environment
17671758

17681759

@@ -2277,8 +2268,13 @@ def create_python_environment(
22772268
python_version_requirement = f"=={override_python_version}"
22782269

22792270
# with cli_feedback("Inspecting Python environment"):
2280-
detected_python, environment = _get_python_env_info(module_file, python, force_generate, override_python_version,
2281-
python_version_requirement)
2271+
detected_python, environment = _get_python_env_info(module_file, python, force_generate)
2272+
environment.python_version_requirement = python_version_requirement
2273+
2274+
if override_python_version:
2275+
# Retaing backward compatibility with old Connect versions
2276+
# that didn't support environment.python.requires
2277+
environment.python = override_python_version
22822278

22832279
if force_generate:
22842280
_warn_on_ignored_requirements(directory, environment.filename)

0 commit comments

Comments
 (0)