From caa1d5c495914f447efc6f2da0c0cadc759e8ba8 Mon Sep 17 00:00:00 2001 From: ian-flores Date: Tue, 3 Feb 2026 06:59:21 -0800 Subject: [PATCH] Enable 30-day automatic backup retention for FSx OpenZFS The FSx OpenZFS file systems were created without automatic_backup_retention_days set, defaulting to 0 (disabled). This meant daily_automatic_backup_start_time had no effect. Set automatic_backup_retention_days=30 for both MULTI_AZ and SINGLE_AZ deployments to enable automatic backups. --- python-pulumi/src/ptd/pulumi_resources/aws_fsx_openzfs_multi.py | 2 ++ .../src/ptd/pulumi_resources/aws_workload_persistent.py | 2 ++ 2 files changed, 4 insertions(+) diff --git a/python-pulumi/src/ptd/pulumi_resources/aws_fsx_openzfs_multi.py b/python-pulumi/src/ptd/pulumi_resources/aws_fsx_openzfs_multi.py index dd79c18..cace791 100644 --- a/python-pulumi/src/ptd/pulumi_resources/aws_fsx_openzfs_multi.py +++ b/python-pulumi/src/ptd/pulumi_resources/aws_fsx_openzfs_multi.py @@ -8,6 +8,7 @@ @dataclasses.dataclass class AWSFsxOpenZfsMultiArgs: + automatic_backup_retention_days: pulumi.Input[int] copy_tags_to_backups: pulumi.Input[bool] copy_tags_to_volumes: pulumi.Input[bool] daily_automatic_backup_start_time: pulumi.Input[str] @@ -86,6 +87,7 @@ def __init__( self.file_system = aws.fsx.OpenZfsFileSystem( f"{name}-filesystem", + automatic_backup_retention_days=props.automatic_backup_retention_days, deployment_type=props.deployment_type, preferred_subnet_id=preferred_subnet_id, subnet_ids=props.subnet_ids, diff --git a/python-pulumi/src/ptd/pulumi_resources/aws_workload_persistent.py b/python-pulumi/src/ptd/pulumi_resources/aws_workload_persistent.py index 573df39..d04fa93 100644 --- a/python-pulumi/src/ptd/pulumi_resources/aws_workload_persistent.py +++ b/python-pulumi/src/ptd/pulumi_resources/aws_workload_persistent.py @@ -835,6 +835,7 @@ def _define_fsx_openzfs(self) -> None: self.fsx_openzfs_fs = ptd.pulumi_resources.aws_fsx_openzfs_multi.AWSFsxOpenZfsMulti( self.workload.compound_name, props=ptd.pulumi_resources.aws_fsx_openzfs_multi.AWSFsxOpenZfsMultiArgs( + automatic_backup_retention_days=30, subnet_ids=self.private_subnet_ids[:2], daily_automatic_backup_start_time=self.workload.cfg.fsx_openzfs_daily_automatic_backup_start_time, deployment_type=deployment_type, @@ -867,6 +868,7 @@ def _define_fsx_openzfs(self) -> None: else: self.fsx_openzfs_fs = aws.fsx.OpenZfsFileSystem( self.workload.compound_name, + automatic_backup_retention_days=30, preferred_subnet_id=(subnet_ids[0] if deployment_type.startswith("MULTI") else None), subnet_ids=subnet_ids, deployment_type=deployment_type,