diff --git a/.idea/compiler.xml b/.idea/compiler.xml index 9a536f5..e0991c0 100644 --- a/.idea/compiler.xml +++ b/.idea/compiler.xml @@ -7,6 +7,7 @@ + diff --git a/.idea/misc.xml b/.idea/misc.xml index d31b37a..732146c 100644 --- a/.idea/misc.xml +++ b/.idea/misc.xml @@ -8,5 +8,5 @@ - + \ No newline at end of file diff --git a/src/main/java/edu/bristol/IMDBRating.java b/src/main/java/edu/bristol/IMDBRating.java index 6021d63..4edf32e 100644 --- a/src/main/java/edu/bristol/IMDBRating.java +++ b/src/main/java/edu/bristol/IMDBRating.java @@ -7,8 +7,8 @@ public class IMDBRating public float addNewRating(int newRating) { - int previousTotal = (int) (currentAverage * ratingCount); - int newTotal = previousTotal + newRating; + float previousTotal = (currentAverage * ratingCount); + float newTotal = previousTotal + newRating; ratingCount++; currentAverage = newTotal / ratingCount; return currentAverage; diff --git a/src/test/java/edu/bristol/IMDBRatingTest.java b/src/test/java/edu/bristol/IMDBRatingTest.java index 76a9e9c..bb95d6c 100644 --- a/src/test/java/edu/bristol/IMDBRatingTest.java +++ b/src/test/java/edu/bristol/IMDBRatingTest.java @@ -15,6 +15,15 @@ public void testAverageRating() assertTrue(averageRating == 2.0, "Adding 1st rating: average should be 2.0"); averageRating = rater.addNewRating(4); - assertTrue(averageRating == 3.0, "Adding 2nd rating: average should be 3.0"); + assertTrue(averageRating == 3, "Adding 2nd rating: average should be 3.0"); + + averageRating = rater.addNewRating(0); + assertTrue(averageRating == 2.0, "Adding 2nd rating: average should be 3.0"); + + averageRating = rater.addNewRating(10); + assertTrue(averageRating == 4.0, "Adding 2nd rating: average should be 3.0"); + + averageRating = rater.addNewRating(4); + assertTrue(averageRating == 4.0, "Adding 2nd rating: average should be 3.0"); } } diff --git a/target/classes/edu/bristol/IMDBRating.class b/target/classes/edu/bristol/IMDBRating.class new file mode 100644 index 0000000..381d3c9 Binary files /dev/null and b/target/classes/edu/bristol/IMDBRating.class differ diff --git a/target/test-classes/edu/bristol/IMDBRatingTest.class b/target/test-classes/edu/bristol/IMDBRatingTest.class new file mode 100644 index 0000000..e39d68d Binary files /dev/null and b/target/test-classes/edu/bristol/IMDBRatingTest.class differ