From a4e1d55a4510d5508ad925ee56eac163ca77d316 Mon Sep 17 00:00:00 2001 From: AMIR Date: Sat, 19 Feb 2022 16:16:33 +0000 Subject: [PATCH] Fixed bug --- .idea/compiler.xml | 1 + .idea/misc.xml | 2 +- src/main/java/edu/bristol/IMDBRating.java | 5 +- src/test/java/edu/bristol/IMDBRatingTest.java | 6 ++ target/classes/edu/bristol/IMDBRating.class | Bin 0 -> 705 bytes .../compile/default-compile/createdFiles.lst | 1 + .../compile/default-compile/inputFiles.lst | 1 + .../default-testCompile/createdFiles.lst | 1 + .../default-testCompile/inputFiles.lst | 1 + .../TEST-edu.bristol.IMDBRatingTest.xml | 62 ++++++++++++++++++ .../edu.bristol.IMDBRatingTest.txt | 4 ++ .../edu/bristol/IMDBRatingTest.class | Bin 0 -> 1051 bytes 12 files changed, 81 insertions(+), 3 deletions(-) create mode 100644 target/classes/edu/bristol/IMDBRating.class create mode 100644 target/maven-status/maven-compiler-plugin/compile/default-compile/createdFiles.lst create mode 100644 target/maven-status/maven-compiler-plugin/compile/default-compile/inputFiles.lst create mode 100644 target/maven-status/maven-compiler-plugin/testCompile/default-testCompile/createdFiles.lst create mode 100644 target/maven-status/maven-compiler-plugin/testCompile/default-testCompile/inputFiles.lst create mode 100644 target/surefire-reports/TEST-edu.bristol.IMDBRatingTest.xml create mode 100644 target/surefire-reports/edu.bristol.IMDBRatingTest.txt create mode 100644 target/test-classes/edu/bristol/IMDBRatingTest.class diff --git a/.idea/compiler.xml b/.idea/compiler.xml index 9a536f5..e0991c0 100644 --- a/.idea/compiler.xml +++ b/.idea/compiler.xml @@ -7,6 +7,7 @@ + diff --git a/.idea/misc.xml b/.idea/misc.xml index d31b37a..5372e92 100644 --- a/.idea/misc.xml +++ b/.idea/misc.xml @@ -8,5 +8,5 @@ - + \ No newline at end of file diff --git a/src/main/java/edu/bristol/IMDBRating.java b/src/main/java/edu/bristol/IMDBRating.java index 6021d63..1b717f9 100644 --- a/src/main/java/edu/bristol/IMDBRating.java +++ b/src/main/java/edu/bristol/IMDBRating.java @@ -7,10 +7,11 @@ public class IMDBRating public float addNewRating(int newRating) { - int previousTotal = (int) (currentAverage * ratingCount); - int newTotal = previousTotal + newRating; + float previousTotal = (currentAverage * ratingCount); + float newTotal = previousTotal + newRating; ratingCount++; currentAverage = newTotal / ratingCount; + System.out.println(currentAverage); return currentAverage; } } diff --git a/src/test/java/edu/bristol/IMDBRatingTest.java b/src/test/java/edu/bristol/IMDBRatingTest.java index 76a9e9c..af5e232 100644 --- a/src/test/java/edu/bristol/IMDBRatingTest.java +++ b/src/test/java/edu/bristol/IMDBRatingTest.java @@ -16,5 +16,11 @@ public void testAverageRating() averageRating = rater.addNewRating(4); assertTrue(averageRating == 3.0, "Adding 2nd rating: average should be 3.0"); + + averageRating = rater.addNewRating(6); + assertTrue(averageRating == 4, "Adding 3rd rating: average should be 4"); + + averageRating = rater.addNewRating(4); + assertTrue(averageRating == 4, "Adding 2nd rating: average should be 4"); } } diff --git a/target/classes/edu/bristol/IMDBRating.class b/target/classes/edu/bristol/IMDBRating.class new file mode 100644 index 0000000000000000000000000000000000000000..9c28253acdcdb9f5cf90a75e73978f394f9347d8 GIT binary patch literal 705 zcmZuv-D(p-7(J6+yG^qBv9-0f{Sp)11h)UZGE?;cKIl zte+Vrr~4Ib;D(1yA6vL7uzCqbz&o)OaU$ThI_&|?VLGC)Mo%Z|D4#~k9Lp$XW~G-7 zWjv5Z+jx<5v-f%?u+h8x#`^-k9F30Dhkp}rTitd?pqyN!Y9~g`b(+tP(@e$!%RF1S zm42F=q3UQWpm8zDhxRVm=IBa%uM!vMUU-~iVTFA-2;5?Hz;i*{2);uE)pK}(bB@}V z0(hHy9S(N~E{n=6yTi!;TY|f!0sS4^TeSOBAc05089SY!b~<^nyLB3Mg0~FZcWfQ( z75RizUvbsqzTvtxpV_Mf%ehG&phDqQO7O1e(UWL$3KELaXz~= PnYmBTVfF#BCA9tkCw7RT literal 0 HcmV?d00001 diff --git a/target/maven-status/maven-compiler-plugin/compile/default-compile/createdFiles.lst b/target/maven-status/maven-compiler-plugin/compile/default-compile/createdFiles.lst new file mode 100644 index 0000000..066862e --- /dev/null +++ b/target/maven-status/maven-compiler-plugin/compile/default-compile/createdFiles.lst @@ -0,0 +1 @@ +edu/bristol/IMDBRating.class diff --git a/target/maven-status/maven-compiler-plugin/compile/default-compile/inputFiles.lst b/target/maven-status/maven-compiler-plugin/compile/default-compile/inputFiles.lst new file mode 100644 index 0000000..d813d0e --- /dev/null +++ b/target/maven-status/maven-compiler-plugin/compile/default-compile/inputFiles.lst @@ -0,0 +1 @@ +/Users/amiromar/Desktop/IMDBRating/src/main/java/edu/bristol/IMDBRating.java diff --git a/target/maven-status/maven-compiler-plugin/testCompile/default-testCompile/createdFiles.lst b/target/maven-status/maven-compiler-plugin/testCompile/default-testCompile/createdFiles.lst new file mode 100644 index 0000000..9e4e3e9 --- /dev/null +++ b/target/maven-status/maven-compiler-plugin/testCompile/default-testCompile/createdFiles.lst @@ -0,0 +1 @@ +edu/bristol/IMDBRatingTest.class diff --git a/target/maven-status/maven-compiler-plugin/testCompile/default-testCompile/inputFiles.lst b/target/maven-status/maven-compiler-plugin/testCompile/default-testCompile/inputFiles.lst new file mode 100644 index 0000000..0645edc --- /dev/null +++ b/target/maven-status/maven-compiler-plugin/testCompile/default-testCompile/inputFiles.lst @@ -0,0 +1 @@ +/Users/amiromar/Desktop/IMDBRating/src/test/java/edu/bristol/IMDBRatingTest.java diff --git a/target/surefire-reports/TEST-edu.bristol.IMDBRatingTest.xml b/target/surefire-reports/TEST-edu.bristol.IMDBRatingTest.xml new file mode 100644 index 0000000..b14be3c --- /dev/null +++ b/target/surefire-reports/TEST-edu.bristol.IMDBRatingTest.xml @@ -0,0 +1,62 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/target/surefire-reports/edu.bristol.IMDBRatingTest.txt b/target/surefire-reports/edu.bristol.IMDBRatingTest.txt new file mode 100644 index 0000000..e9a2cbc --- /dev/null +++ b/target/surefire-reports/edu.bristol.IMDBRatingTest.txt @@ -0,0 +1,4 @@ +------------------------------------------------------------------------------- +Test set: edu.bristol.IMDBRatingTest +------------------------------------------------------------------------------- +Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec diff --git a/target/test-classes/edu/bristol/IMDBRatingTest.class b/target/test-classes/edu/bristol/IMDBRatingTest.class new file mode 100644 index 0000000000000000000000000000000000000000..f7493219b9a8fd8b65cc9bdf914781977235cb2d GIT binary patch literal 1051 zcmaJ<%Wl&^6g}fOu`%f@O&_!c426=E68E)g0Xa}rs+1O~ts+2dCh;hpklK|WWy=q+ zL`eJqYc>>t#0T&p`~`?RPC{6;^+z^X&(KM_9F>A!9(#Ba0lvXq%sM zr^Ef0^Q_Sp&6pwgQ2H`{%#bOS>jq4QN#P|s&yq$CDyXrA9#!#wy9(CF)QEZ3lkPVxkijcR29UTQp$Fm#4Uac%! z7)Q~-L>`lvVz7g-<+KyxMe#(&B6RqPbgEG#!dM1=#9;9>ISdm)j7u+T17!zsNFUuS z*K@AfCo?-Bv+8@7kXfrN>+V~{{|3WCkN;YDSNf>pdrG2cCa1>B>I z?5DbxHvfW-4At7-VZ1oQmEEQ67g$^K?}`}y@DYao33{e5`W1yGqYq3EfEfjh=2E0E z_x@kQ^+Ch`<(pJi3^OUiMOY~}6T`GdNZuInD_{dfR55{lOyN1EAxVQ$VRxDKR1D)4 t%2*^dCK|YpB~tW&P8DJP#;j(*aM_g0CS5k+GE@jrH{#IFuuM_I%3q1@@R$Gq literal 0 HcmV?d00001