Vigil.call/2 and rescue

[ericsullivan]

I just received a RuntimeError:

expected Vigil.call/2 to return a Plug.Conn, all plugs must receive a connection (conn) and return a connection, got: :ok

caused by the rescue returning :ok

def call(%Plug.Conn{} = conn, opts) do
    ...
  rescue
    e ->
      LogFormatter.log(conn, e, opts)
  end

Did you want to call reraise/2 or forbid_connection?

I didn't set the log_level in the plug so I'm not sure of the underlying exception.

[alex0112]

Hi @ericsullivan ! I'm the original author of this plug. I'm no longer at Podium, but I just noticed this issue today. (Thanks for your patience, I only just noticed the issue today)

My thought here after glancing at the issue briefly is to have the rescue return the original conn, erring on the side of assuming that the error occurred within the plug.