Repairing over blocks

[TylerS1066]

CreeperHeal will attempt to repair over blocks which may have already been repaired via another plugin (such as Movecraft-Warfare). To prevent this from spawning potentially thousands of item entities, CreeperHeal should first check that the block is empty or a liquid (like we do in Movecraft-Repair), or at least expose this as a config option.

[pmdevita]

If a block is in the way when CreeperHeal is repairing, it will break the block into an item. This solution was implemented with the assumption that this usually happens because a player might have accidentally placed a block in the way, so this is to return the block back to them.

Could you describe a bit more about how Warfare works? Maybe we can add another compatibility check to CreeperHeal for it, the system is already in place now to implement more things like we did for Movecraft.

[TylerS1066]

In this case, Warfare's Assault feature allows players to attack a protected region and damage blocks. If they succeed in damaging enough blocks, the region owners have to pay a fee to repair the region. If the attackers do not damage enough, the region is repaired for free.

The problem occurs usually in the second case: attackers have blown up parts of the region, but not enough, and the region gets repaired by Movecraft-Warfare and then later Creeperheal comes in to repair as well. Usually, the attackers have damaged thousands of blocks, and this generates a ton of items.

[pmdevita]

Apologies for the late reply.

OK I'm guessing this is the event handler in question, just gonna link this here so I don't lose track of it. https://github.com/APDevTeam/Movecraft-Warfare/blob/main/src/main/java/net/countercraft/movecraft/warfare/features/assault/listener/AssaultExplosionListener.java

To clarify, do you want Creeperheal to repair damage in the first case? If you don't want Creeperheal to run in these regions at all, we can add a check to make it avoid touching those blocks, similarly to what we did with the original Movecraft plugin. It looks like you already do a check like this in the event handler so I can just borrow that.

In the case you just want it to restore non-assault related damage, maybe the plugin could check if the region is under assault and not touch anything if it is.

If you do want Creeperheal to repair damage in the first case, since that repair needs to wait for the player to pay for it, I think the best thing to do would be to collect the blocks yourself and then sending the list of them to Creeperheal once the player pays. You can call createNewExplosion and pass the block list. I can add a flag that lets you bypass the cooldown and kicks off the repair immediately.

[TylerS1066]

If you don't want Creeperheal to run in these regions at all, we can add a check to make it avoid touching those blocks, similarly to what we did with the original Movecraft plugin.

The issue is that we don't keep track of what blocks are damaged, so there's not a method to remove them from Creeperheal. The solution to this is what I described in the initial comment, to not repair over already existing blocks, or at least have that as an option.

[pmdevita]

I meant "touching those blocks" as in we look up whether their Location is in a region currently under assault, the same way you do it in your event listener. If you already are taking care of repairs in a region under assault, we can just mask out any active assault regions to Creeperheal and it will ignore them. Although now that you mention it, how do you know what blocks to replace in a repair if you aren't tracking the blocks?

I'm still pretty confused as to what's going on, if you're cool with it do you want to chat over Discord? https://discord.gg/S3UAdeQV7K

I'm not 100% against your solution, but it's a very blunt approach and could cause unexpected behavior to players and the accidental destroying of blocks and items. I would much rather prefer a more elegant and narrow solution, free from side effects.