Can't bulk-update Yes/No fields to yes

[Zenthae]

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing issue for this?

• I have searched the existing issues

GLPI Version

10.0.17

Plugin version

1.21.18

Bug description

When i try to bulk update a custom Yes/No fields on computers, i get the following error :

Relevant log output

I don't see anything happen in the logs when i update a value

Page URL

No response

Steps To reproduce

1. Select a computer
2. Action
3. Update
4. select the custom YES/NO value
5. pass it to yes
6. save
7. error

Your GLPI setup information

Information about system installation and configuration

GLPI 10.0.17 ( => /var/www/html/glpi)
Installation mode: TARBALL
Current language:en_GB

Server

 

Operating system: Linux glpi 5.15.0-130-generic #​140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64

PHP 8.1.30 apache2handler (Core, FFI, PDO, Phar, Reflection, SPL, SimpleXML, Zend OPcache, apache2handler, bz2, calendar, ctype,

curl, date, dom, exif, fileinfo, filter, ftp, gd, gettext, hash, iconv, igbinary, imap, intl, json, ldap, libxml, mbstring,

mysqli, mysqlnd, openssl, pcre, pdo_mysql, posix, readline, redis, session, shmop, sockets, sodium, standard, sysvmsg, sysvsem,

sysvshm, tokenizer, xml, xmlreader, xmlrpc, xmlwriter, xsl, zip, zlib)

Setup: max_execution_time="30" memory_limit="128M" post_max_size="8M" safe_mode="" session.save_handler="files"

upload_max_filesize="2M" disable_functions=""

Software: Apache/2.4.62 (Debian) (Apache/2.4.62 (Debian) Server at inventaire-test.insa-rennes.fr Port 80

)

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:128.0) Gecko/20100101 Firefox/128.0

Server Software: MySQL Community Server - GPL

Server Version: 8.0.41

Server SQL Mode: STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION

Parameters: glpi@mysql/glpidb

Host info: mysql via TCP/IP

PHP version (8.1.30) is supported.

Sessions configuration is OK.

Allocated memory is sufficient.

mysqli extension is installed.

Following extensions are installed: dom, fileinfo, filter, libxml, json, simplexml, xmlreader, xmlwriter.

curl extension is installed.

gd extension is installed.

intl extension is installed.

zlib extension is installed.

The constant SODIUM_CRYPTO_AEAD_XCHACHA20POLY1305_IETF_NPUBBYTES is present.

Database engine version (8.0.41) is supported.

No files from previous GLPI version detected.

The log file has been created successfully.

Write access to /var/www/html/glpi/files/_cache has been validated.

Write access to /var/www/html/glpi/files/_cron has been validated.

Write access to /var/www/html/glpi/files has been validated.

Write access to /var/www/html/glpi/files/_dumps has been validated.

Write access to /var/www/html/glpi/files/_graphs has been validated.

Write access to /var/www/html/glpi/files/_lock has been validated.

Write access to /var/www/html/glpi/files/_pictures has been validated.

Write access to /var/www/html/glpi/files/_plugins has been validated.

Write access to /var/www/html/glpi/files/_rss has been validated.

Write access to /var/www/html/glpi/files/_sessions has been validated.

Write access to /var/www/html/glpi/files/_tmp has been validated.

Write access to /var/www/html/glpi/files/_uploads has been validated.
Web server root directory configuration seems safe.

Sessions configuration is secured.

OS and PHP are relying on 64 bits integers.

exif extension is installed.

ldap extension is installed.

openssl extension is installed.

Following extensions are installed: bz2, Phar, zip.

Zend OPcache extension is installed.

Following extensions are installed: ctype, iconv, mbstring, sodium.

Write access to /var/www/html/glpi/marketplace has been validated.

Access to timezone database (mysql) is not allowed.

GLPI constants

 

GLPI_ROOT: "/var/www/html/glpi"

GLPI_CONFIG_DIR: "/var/www/html/glpi/config"

GLPI_VAR_DIR: "/var/www/html/glpi/files"

GLPI_MARKETPLACE_DIR: "/var/www/html/glpi/marketplace"

GLPI_USE_CSRF_CHECK: "1"

GLPI_CSRF_EXPIRES: "7200"

GLPI_CSRF_MAX_TOKENS: "100"

GLPI_USE_IDOR_CHECK: "1"

GLPI_IDOR_EXPIRES: "7200"

GLPI_ALLOW_IFRAME_IN_RICH_TEXT: false

GLPI_SERVERSIDE_URL_ALLOWLIST: ["/^(https?|feed):\/\/[^@:]+(\/.*)?$/"]

GLPI_TELEMETRY_URI: "https://telemetry.glpi-project.org"

GLPI_INSTALL_MODE: "TARBALL"

GLPI_NETWORK_MAIL: "glpi@teclib.com"

GLPI_NETWORK_SERVICES: "https://services.glpi-network.com"

GLPI_MARKETPLACE_ALLOW_OVERRIDE: true

GLPI_MARKETPLACE_MANUAL_DOWNLOADS: true

GLPI_USER_AGENT_EXTRA_COMMENTS: ""

GLPI_DISABLE_ONLY_FULL_GROUP_BY_SQL_MODE: "1"

GLPI_AJAX_DASHBOARD: "1"

GLPI_CALDAV_IMPORT_STATE: 0

GLPI_DEMO_MODE: "0"

GLPI_CENTRAL_WARNINGS: "1"

GLPI_TEXT_MAXSIZE: "4000"

GLPI_DOC_DIR: "/var/www/html/glpi/files"

GLPI_CACHE_DIR: "/var/www/html/glpi/files/_cache"

GLPI_CRON_DIR: "/var/www/html/glpi/files/_cron"

GLPI_DUMP_DIR: "/var/www/html/glpi/files/_dumps"

GLPI_GRAPH_DIR: "/var/www/html/glpi/files/_graphs"

GLPI_LOCAL_I18N_DIR: "/var/www/html/glpi/files/_locales"

GLPI_LOCK_DIR: "/var/www/html/glpi/files/_lock"

GLPI_LOG_DIR: "/var/www/html/glpi/files/_log"

GLPI_PICTURE_DIR: "/var/www/html/glpi/files/_pictures"

GLPI_PLUGIN_DOC_DIR: "/var/www/html/glpi/files/_plugins"

GLPI_RSS_DIR: "/var/www/html/glpi/files/_rss"

GLPI_SESSION_DIR: "/var/www/html/glpi/files/_sessions"

GLPI_TMP_DIR: "/var/www/html/glpi/files/_tmp"

GLPI_UPLOAD_DIR: "/var/www/html/glpi/files/_uploads"

GLPI_INVENTORY_DIR: "/var/www/html/glpi/files/_inventories"

GLPI_NETWORK_REGISTRATION_API_URL: "https://services.glpi-network.com/api/registration/"

GLPI_MARKETPLACE_PLUGINS_API_URI: "https://services.glpi-network.com/api/marketplace/"

GLPI_I18N_DIR: "/var/www/html/glpi/locales"

GLPI_VERSION: "10.0.17"

GLPI_SCHEMA_VERSION: "10.0.17"

GLPI_MARKETPLACE_PRERELEASES: false

GLPI_MIN_PHP: "7.4.0"

GLPI_MAX_PHP: "8.4.0"

GLPI_YEAR: "2024"

Libraries

 

htmlawed/htmlawed version 1.2.14 in (/var/www/html/glpi/vendor/htmlawed/htmlawed)

phpmailer/phpmailer version 6.8.0 in (/var/www/html/glpi/vendor/phpmailer/phpmailer/src)

simplepie/simplepie version 1.5.8 in (/var/www/html/glpi/vendor/simplepie/simplepie/library)

tecnickcom/tcpdf version 6.7.5 in (/var/www/html/glpi/vendor/tecnickcom/tcpdf)

michelf/php-markdown in (/var/www/html/glpi/vendor/michelf/php-markdown/Michelf)

true/punycode in (/var/www/html/glpi/vendor/true/punycode/src)

iamcal/lib_autolink in (/var/www/html/glpi/vendor/iamcal/lib_autolink)

sabre/dav in (/var/www/html/glpi/vendor/sabre/dav/lib/DAV)

sabre/http in (/var/www/html/glpi/vendor/sabre/http/lib)

sabre/uri in (/var/www/html/glpi/vendor/sabre/uri/lib)

sabre/vobject in (/var/www/html/glpi/vendor/sabre/vobject/lib)

laminas/laminas-i18n in (/var/www/html/glpi/vendor/laminas/laminas-i18n/src)

laminas/laminas-servicemanager in (/var/www/html/glpi/vendor/laminas/laminas-servicemanager/src)

monolog/monolog in (/var/www/html/glpi/vendor/monolog/monolog/src/Monolog)

sebastian/diff in (/var/www/html/glpi/vendor/sebastian/diff/src)

donatj/phpuseragentparser in (/var/www/html/glpi/vendor/donatj/phpuseragentparser/src/UserAgent)

elvanto/litemoji in (/var/www/html/glpi/vendor/elvanto/litemoji/src)

symfony/console in (/var/www/html/glpi/vendor/symfony/console)

scssphp/scssphp in (/var/www/html/glpi/vendor/scssphp/scssphp/src)

laminas/laminas-mail in (/var/www/html/glpi/vendor/laminas/laminas-mail/src/Protocol)

laminas/laminas-mime in (/var/www/html/glpi/vendor/laminas/laminas-mime/src)

rlanvin/php-rrule in (/var/www/html/glpi/vendor/rlanvin/php-rrule/src)

ramsey/uuid in (/var/www/html/glpi/vendor/ramsey/uuid/src)

psr/log in (/var/www/html/glpi/vendor/psr/log/Psr/Log)

psr/simple-cache in (/var/www/html/glpi/vendor/psr/simple-cache/src)

psr/cache in (/var/www/html/glpi/vendor/psr/cache/src)

league/csv in (/var/www/html/glpi/vendor/league/csv/src)

mexitek/phpcolors in (/var/www/html/glpi/vendor/mexitek/phpcolors/src/Mexitek/PHPColors)

guzzlehttp/guzzle in (/var/www/html/glpi/vendor/guzzlehttp/guzzle/src)

guzzlehttp/psr7 in (/var/www/html/glpi/vendor/guzzlehttp/psr7/src)

glpi-project/inventory_format in (/var/www/html/glpi/vendor/glpi-project/inventory_format/lib/php)

wapmorgan/unified-archive in (/var/www/html/glpi/vendor/wapmorgan/unified-archive/src)

paragonie/sodium_compat in (/var/www/html/glpi/vendor/paragonie/sodium_compat/src)

symfony/cache in (/var/www/html/glpi/vendor/symfony/cache)

html2text/html2text in (/var/www/html/glpi/vendor/html2text/html2text/src)

symfony/css-selector in (/var/www/html/glpi/vendor/symfony/css-selector)

symfony/dom-crawler in (/var/www/html/glpi/vendor/symfony/dom-crawler)

twig/twig in (/var/www/html/glpi/vendor/twig/twig/src)

twig/string-extra in (/var/www/html/glpi/vendor/twig/string-extra)

symfony/polyfill-ctype not found

symfony/polyfill-iconv not found

symfony/polyfill-mbstring not found

symfony/polyfill-php80 not found

symfony/polyfill-php81 not found

symfony/polyfill-php82 in (/var/www/html/glpi/vendor/symfony/polyfill-php82)

league/oauth2-client in (/var/www/html/glpi/vendor/league/oauth2-client/src/Provider)

league/oauth2-google in (/var/www/html/glpi/vendor/league/oauth2-google/src/Provider)

thenetworg/oauth2-azure in (/var/www/html/glpi/vendor/thenetworg/oauth2-azure/src/Provider)

phpCas version 1.3.8 in (/usr/share/php/CAS/source)

LDAP directories

 

Server: 'ldap-test.insa-rennes.fr', Port: '389', BaseDN: 'dc=insa-rennes,dc=fr', Connection filter:

'(objectClass=inetOrgPerson)', RootDN: 'cn=web,ou=admin,dc=insa-rennes,dc=fr', Use TLS: none

SQL replicas

 

Not active

Notifications

 

Way of sending emails: SMTP (anonymous@zimbra.insa-rennes.fr)

Plugins list

 

advanceddashboard    Name: advanceddashboard              Version: 1.6.2      State: Enabled

Install Method: Marketplace

news                 Name: Alertes                        Version: 1.12.4     State: Enabled

Install Method: Marketplace

branding             Name: Branding                       Version: 2.0.3      State: Enabled

Install Method: Marketplace

fields               Name: Champs supplémentaires         Version: 1.21.18    State: Enabled

Install Method: Marketplace

datainjection        Name: Data Injection                 Version: 2.14.1     State: Enabled

Install Method: Marketplace

geststock            Name: Gestion du stock               Version: 2.1.1      State: Enabled

Install Method: Marketplace

glpiinventory        Name: GLPI Inventory                 Version: 1.4.0      State: Enabled

Install Method: Marketplace

manufacturersimports Name: Imports fabricants             Version: 3.0.9      State: Enabled

Install Method: Marketplace

oauthsso             Name: oauthsso                       Version: 1.10.1     State: Enabled

Install Method: Marketplace

collaborativetools   Name: Outils collaboratifs           Version: 1.2.5      State: Enabled

Install Method: Marketplace

ldaptools            Name: Outils LDAP                    Version: 0.1.0      State: Enabled

Install Method: Marketplace

mreporting           Name: Plus de rapports               Version: 1.8.6      State: Enabled

Install Method: Marketplace

reports              Name: Rapports                       Version: 1.16.0     State: Enabled

Install Method: Marketplace

statecheck           Name: Régles de vérification d'état  Version: 2.4.4      State: Enabled

Install Method: Marketplace

webresources         Name: Web Resources                  Version: 2.0.4      State: Enabled

Install Method: Marketplace

Anything else?

No response

[Zenthae]

When i setup a dropdown fields and create the value Yes and N, i can bulk update, so the issue is with Yes/No premade option

[Zenthae]

The compatibility error is at line 1660 of file src/MassiveAction.php in GLPI (not the plugin) files.
As you can see in the dumps, entities_id never match.
I tested by creating a new custom Yes/No field when under the root entity, and i get the same result 0 != 3

case 'update':
                if (
                    (!isset($ma->POST['search_options']))
                    || (!isset($ma->POST['search_options'][$item->getType()]))
                ) {
                    return false;
                }
                $index     = $ma->POST['search_options'][$item->getType()];
                $searchopt = Search::getCleanedOptions($item->getType(), UPDATE);
                $input     = $ma->POST;
                if (isset($searchopt[$index])) {
                   /// Infocoms case
                    if (Search::isInfocomOption($item->getType(), $index)) {
                        $ic               = new Infocom();
                        $link_entity_type = -1;
                        $is_recursive     = 0;
                       /// Specific entity item
                        if ($searchopt[$index]["table"] == "glpi_suppliers") {
                             $ent = new Supplier();
                            if ($ent->getFromDB($input[$input["field"]])) {
                                $link_entity_type = $ent->fields["entities_id"];
                                $is_recursive     = $ent->fields["is_recursive"];
                            }
                        }
                        foreach ($ids as $key) {
                            if ($item->getFromDB($key)) {
                                if (
                                    ($link_entity_type < 0)
                                    || ($link_entity_type == $item->getEntityID())
                                    || ($is_recursive
                                    && in_array(
                                        $link_entity_type,
                                        getAncestorsOf(
                                            "glpi_entities",
                                            $item->getEntityID()
                                        )
                                    ))
                                ) {
                                    $input2 = [
                                        'items_id'  => $key,
                                        'itemtype'  => $item->getType()
                                    ];

                                    if ($ic->can(-1, CREATE, $input2)) {
                                     // Add infocom if not exists
                                        if (!$ic->getFromDBforDevice($item->getType(), $key)) {
                                            $input2["items_id"] = $key;
                                            $input2["itemtype"] = $item->getType();
                                            unset($ic->fields);
                                            $ic->add($input2);
                                            $ic->getFromDBforDevice($item->getType(), $key);
                                        }
                                        $id = $ic->fields["id"];
                                        unset($ic->fields);
                                        if (
                                            $ic->update(['id'            => $id,
                                                $input["field"] => $input[$input["field"]]
                                            ])
                                        ) {
                                            $ma->itemDone($item->getType(), $key, MassiveAction::ACTION_OK);
                                        } else {
                                            $ma->itemDone($item->getType(), $key, MassiveAction::ACTION_KO);
                                            $ma->addMessage($item->getErrorMessage(ERROR_ON_ACTION));
                                        }
                                    } else {
                                        $ma->itemDone($item->getType(), $key, MassiveAction::ACTION_NORIGHT);
                                        $ma->addMessage($item->getErrorMessage(ERROR_RIGHT));
                                    }
                                } else {
                                    $ma->itemDone($item->getType(), $key, MassiveAction::ACTION_KO);
                                    $ma->addMessage($item->getErrorMessage(ERROR_COMPAT));
                                }
                            } else {
                                $ma->itemDone($item->getType(), $key, MassiveAction::ACTION_KO);
                                $ma->addMessage($item->getErrorMessage(ERROR_NOT_FOUND));
                            }
                        }
                    } else { /// Not infocoms
                        $link_entity_type = [];
                       /// Specific entity item
                        $itemtable = getTableForItemType($item->getType());
                        $itemtype2 = getItemTypeForTable($searchopt[$index]["table"]);

                        if ($item2 = getItemForItemtype($itemtype2)) {
                            if (
                                ($index != 80) // No entities_id fields
                                && ($searchopt[$index]["table"] != $itemtable)
                                && $item2->isEntityAssign()
                                && $item->isEntityAssign()
                            ) {
                                if ($item2->getFromDB($input[$input["field"]])) {
                                    if (
                                        isset($item2->fields["entities_id"])
                                        && ($item2->fields["entities_id"] >= 0)
                                    ) {
                                        if (
                                            isset($item2->fields["is_recursive"])
                                            && $item2->fields["is_recursive"]
                                        ) {
                                             $link_entity_type = getSonsOf(
                                                "glpi_entities",
                                                $item2->fields["entities_id"]
                                            );
                                        } else {
                                            $link_entity_type[] = $item2->fields["entities_id"];
                                        }
                                    }
                                }
                            }
                        }
                        foreach ($ids as $key) {
                            if (
                                $item->canEdit($key)
                                && $item->canMassiveAction(
                                    $action,
                                    $input['field'],
                                    $input[$input["field"]]
                                )
                            ) {
                                if (
                                    (count($link_entity_type) == 0)
                                    || in_array($item->fields["entities_id"], $link_entity_type)
                                ) {
                                    if (
                                        $item->update(['id'            => $key,
                                            $input["field"] => $input[$input["field"]]
                                        ])
                                    ) {
                                        $ma->itemDone($item->getType(), $key, MassiveAction::ACTION_OK);
                                    } else {
                                        $ma->itemDone($item->getType(), $key, MassiveAction::ACTION_KO);
                                        $ma->addMessage($item->getErrorMessage(ERROR_ON_ACTION));
                                    }
                                } else {
                                    $ma->itemDone($item->getType(), $key, MassiveAction::ACTION_KO);
                                    $ma->addMessage($item->getErrorMessage(ERROR_COMPAT)); <-- Error message from here
                                }
                            } else {
                                $ma->itemDone($item->getType(), $key, MassiveAction::ACTION_NORIGHT);
                                $ma->addMessage($item->getErrorMessage(ERROR_RIGHT));
                            }
                        }
                    }
                }
                break;

string(27) "item2 fields"
array(7) {
  ["id"]=>
  int(1)
  ["items_id"]=>
  int(4648)
  ["itemtype"]=>
  string(8) "Computer"
  ["plugin_fields_containers_id"]=>
  int(16)
  ["entities_id"]=>
  int(0)
  ["is_recursive"]=>
  int(0)
  ["testfield"]=>
  int(0)
}

string(14) "item fields : "
array(30) {
  ["id"]=>
  int(4648)
  ["entities_id"]=>
  int(3)
  ["name"]=>
  string(14) "po-b11s114-015"
  ["serial"]=>
  string(10) "5CD221D1R5"
  ["otherserial"]=>
  string(0) ""
  ["contact"]=>
  string(20) "Kevin@PO-B11S114-015"
  ["contact_num"]=>
  NULL
  ["users_id_tech"]=>
  int(0)
  ["groups_id_tech"]=>
  int(7)
  ["comment"]=>
  string(5) "Kevin"
  ["date_mod"]=>
  string(19) "2025-01-29 13:33:31"
  ["autoupdatesystems_id"]=>
  int(1)
  ["locations_id"]=>
  int(1632)
  ["networks_id"]=>
  int(0)
  ["computermodels_id"]=>
  int(201)
  ["computertypes_id"]=>
  int(2)
  ["is_template"]=>
  int(0)
  ["template_name"]=>
  NULL
  ["manufacturers_id"]=>
  int(47)
  ["is_deleted"]=>
  int(0)
  ["is_dynamic"]=>
  int(1)
  ["users_id"]=>
  int(2485)
  ["groups_id"]=>
  int(7)
  ["states_id"]=>
  int(2)
  ["ticket_tco"]=>
  string(6) "0.0000"
  ["uuid"]=>
  string(36) "5B347167-A604-45EB-9416-926995D167C3"
  ["date_creation"]=>
  string(19) "2024-03-01 16:22:07"
  ["is_recursive"]=>
  int(0)
  ["last_inventory_update"]=>
  string(19) "2025-01-22 16:09:52"
  ["last_boot"]=>
  string(19) "2025-01-21 08:26:27"
}

[stonebuzz]

Fixed on glpi side by glpi-project/glpi#19706