Fix translations removal, ensure headers translations are removed as well

Author: trasher

inc/container.class.php

@@ -356,13 +356,12 @@ function pre_deleteItem() {
          }
 
          //delete label translations
-         $translation = new PluginFieldsLabelTranslation();
-         $translation->delete(
-            [
-               'itemtype' => self::getType(),
-               'items_id' => $this->getID()
-            ]
-         );
+         $translation_obj = new PluginFieldsLabelTranslation();
+         $translations = $translation_obj->find("plugin_fields_itemtype = '" . self::getType() .
+                                                "' AND plugin_fields_items_id = ". $this->fields['id']);
+         foreach ($translations as $translation_id => $translation) {
+            $translation_obj->delete(['id' => $translation_id]);
+         }
 
          //delete table
          if (class_exists($classname)) {

inc/field.class.php

@@ -136,14 +136,6 @@ function pre_deleteItem() {
                PluginFieldsDropdown::getClassname($this->fields['name']));
          }
 
-         $translation = new PluginFieldsLabelTranslation();
-         $translation->delete(
-            [
-               'itemtype' => self::getType(),
-               'items_id' => $this->getID()
-            ]
-         );
-
          $container_obj = new PluginFieldsContainer;
          $container_obj->getFromDB($this->fields['plugin_fields_containers_id']);
          foreach (json_decode($container_obj->fields['itemtypes']) as $itemtype) {
@@ -154,6 +146,14 @@ function pre_deleteItem() {
          $classname::removeField($this->fields['name']);
       }
 
+      //delete label translations
+      $translation_obj = new PluginFieldsLabelTranslation();
+      $translations = $translation_obj->find("plugin_fields_itemtype = '" . self::getType() .
+                                             "' AND plugin_fields_items_id = ". $this->fields['id']);
+      foreach ($translations as $translation_id => $translation) {
+         $translation_obj->delete(['id' => $translation_id]);
+      }
+
       if (isset($oldname)) {
          $this->fields['name'] = $oldname;
       }