From a07471f50b2d7c9901dab148488127ccdd89e39b Mon Sep 17 00:00:00 2001
From: Sergei Zharinov <zharinov@users.noreply.github.com>
Date: Sun, 4 Jan 2026 00:11:49 -0300
Subject: [PATCH] refactor: extract quantifier_operator_kind helper

---
 crates/plotnik-lib/src/compile/navigation.rs | 58 +++++++++-----------
 1 file changed, 25 insertions(+), 33 deletions(-)

diff --git a/crates/plotnik-lib/src/compile/navigation.rs b/crates/plotnik-lib/src/compile/navigation.rs
index cdd4bd9f..78b57792 100644
--- a/crates/plotnik-lib/src/compile/navigation.rs
+++ b/crates/plotnik-lib/src/compile/navigation.rs
@@ -101,49 +101,41 @@ pub fn is_down_nav(nav: Option<Nav>) -> bool {
     matches!(nav, Some(Nav::Down | Nav::DownSkip | Nav::DownExact))
 }
 
-/// Check if expression is optional (?) or star (*) - patterns that can match zero times.
+/// Extract the operator kind from an expression if it's a quantifier.
 /// Unwraps CapturedExpr if present.
-pub fn is_skippable_quantifier(expr: &Expr) -> bool {
-    use crate::parser::cst::SyntaxKind;
-
-    // Unwrap CapturedExpr to check the inner quantifier
+fn quantifier_operator_kind(expr: &Expr) -> Option<crate::parser::cst::SyntaxKind> {
     let expr = match expr {
-        Expr::CapturedExpr(cap) => match cap.inner() {
-            Some(inner) => inner,
-            None => return false,
-        },
+        Expr::CapturedExpr(cap) => cap.inner()?,
         e => e.clone(),
     };
 
-    let Expr::QuantifiedExpr(q) = &expr else {
-        return false;
-    };
-    let Some(op) = q.operator() else {
-        return false;
-    };
-    matches!(
-        op.kind(),
-        SyntaxKind::Question
-            | SyntaxKind::QuestionQuestion
-            | SyntaxKind::Star
-            | SyntaxKind::StarQuestion
-    )
+    let Expr::QuantifiedExpr(q) = &expr else { return None };
+    Some(q.operator()?.kind())
+}
+
+/// Check if expression is optional (?) or star (*) - patterns that can match zero times.
+pub fn is_skippable_quantifier(expr: &Expr) -> bool {
+    use crate::parser::cst::SyntaxKind;
+    quantifier_operator_kind(expr).is_some_and(|k| {
+        matches!(
+            k,
+            SyntaxKind::Question
+                | SyntaxKind::QuestionQuestion
+                | SyntaxKind::Star
+                | SyntaxKind::StarQuestion
+        )
+    })
 }
 
 /// Syntactic check for star/plus quantifier (fallback when type info unavailable).
 pub fn is_star_or_plus_quantifier(expr: Option<&Expr>) -> bool {
     use crate::parser::cst::SyntaxKind;
-
-    let Some(Expr::QuantifiedExpr(q)) = expr else {
-        return false;
-    };
-    let Some(op) = q.operator() else {
-        return false;
-    };
-    matches!(
-        op.kind(),
-        SyntaxKind::Star | SyntaxKind::StarQuestion | SyntaxKind::Plus | SyntaxKind::PlusQuestion
-    )
+    expr.and_then(quantifier_operator_kind).is_some_and(|k| {
+        matches!(
+            k,
+            SyntaxKind::Star | SyntaxKind::StarQuestion | SyntaxKind::Plus | SyntaxKind::PlusQuestion
+        )
+    })
 }
 
 /// Determines if an expression creates a scope boundary when captured.