Retries on transient auth errors

Author: KrisBraun

twister/cli/commands/deploy.ts

@@ -10,6 +10,29 @@ import * as out from "../utils/output";
 import { handleSSEStream } from "../utils/sse";
 import { resolveToken } from "../utils/token.js";
 
+async function fetchWithRetry(
+  url: string,
+  options: RequestInit,
+  maxRetries = 3
+): Promise<Response> {
+  for (let attempt = 0; attempt <= maxRetries; attempt++) {
+    try {
+      const response = await fetch(url, options);
+      if (response.status < 500 || attempt === maxRetries) {
+        return response;
+      }
+      // 5xx — retry with backoff
+      const delay = 1000 * Math.pow(2, attempt);
+      await new Promise((r) => setTimeout(r, delay));
+    } catch (error) {
+      if (attempt === maxRetries) throw error;
+      const delay = 1000 * Math.pow(2, attempt);
+      await new Promise((r) => setTimeout(r, delay));
+    }
+  }
+  throw new Error("Retry logic error");
+}
+
 // Publisher types for API interaction
 interface Publisher {
   id: number;
@@ -65,7 +88,7 @@ async function createNewPublisher(
   // Try to get user's name for default
   let defaultName = "";
   try {
-    const userResponse = await fetch(`${apiUrl}/v1/twist/user`, {
+    const userResponse = await fetchWithRetry(`${apiUrl}/v1/twist/user`, {
       method: "GET",
       headers: {
         Authorization: `Bearer ${deployToken}`,
@@ -83,6 +106,12 @@ async function createNewPublisher(
         "Your login token is invalid or has expired. Please run 'plot login' to authenticate."
       );
       process.exit(1);
+    } else if (userResponse.status >= 500) {
+      out.error(
+        "Server error",
+        "The Plot API is temporarily unavailable. Please try again."
+      );
+      process.exit(1);
     }
   } catch (error) {
     // Ignore error, just won't have default
@@ -130,17 +159,20 @@ async function createNewPublisher(
   try {
     out.progress(`Creating publisher "${publisherName}"...`);
 
-    const createResponse = await fetch(`${apiUrl}/v1/twist/publishers`, {
-      method: "POST",
-      headers: {
-        "Content-Type": "application/json",
-        Authorization: `Bearer ${deployToken}`,
-      },
-      body: JSON.stringify({
-        name: publisherName,
-        url: response.url || null,
-      } as NewPublisher),
-    });
+    const createResponse = await fetchWithRetry(
+      `${apiUrl}/v1/twist/publishers`,
+      {
+        method: "POST",
+        headers: {
+          "Content-Type": "application/json",
+          Authorization: `Bearer ${deployToken}`,
+        },
+        body: JSON.stringify({
+          name: publisherName,
+          url: response.url || null,
+        } as NewPublisher),
+      }
+    );
 
     if (!createResponse.ok) {
       if (createResponse.status === 401) {
@@ -150,6 +182,13 @@ async function createNewPublisher(
         );
         process.exit(1);
       }
+      if (createResponse.status >= 500) {
+        out.error(
+          "Server error",
+          "The Plot API is temporarily unavailable. Please try again."
+        );
+        process.exit(1);
+      }
       const errorText = await createResponse.text();
       out.error("Failed to create publisher", errorText);
       process.exit(1);
@@ -312,7 +351,7 @@ export async function deployCommand(options: DeployOptions) {
     const urlPath = deploymentId || "personal";
 
     try {
-      const twistInfoResponse = await fetch(
+      const twistInfoResponse = await fetchWithRetry(
         `${options.apiUrl}/v1/twist/${urlPath}`,
         {
           method: "GET",
@@ -336,6 +375,12 @@ export async function deployCommand(options: DeployOptions) {
           "Your login token is invalid or has expired. Please run 'plot login' to authenticate."
         );
         process.exit(1);
+      } else if (twistInfoResponse.status >= 500) {
+        out.error(
+          "Server error",
+          "The Plot API is temporarily unavailable. Please try again."
+        );
+        process.exit(1);
       } else if (twistInfoResponse.status !== 404) {
         // Log non-404 errors, but continue with publisher setup
         const errorText = await twistInfoResponse.text();
@@ -359,7 +404,7 @@ export async function deployCommand(options: DeployOptions) {
 
       try {
         // Fetch accessible publishers
-        const publishersResponse = await fetch(
+        const publishersResponse = await fetchWithRetry(
           `${options.apiUrl}/v1/twist/publishers`,
           {
             method: "GET",
@@ -378,6 +423,13 @@ export async function deployCommand(options: DeployOptions) {
             );
             process.exit(1);
           }
+          if (publishersResponse.status >= 500) {
+            out.error(
+              "Server error",
+              "The Plot API is temporarily unavailable. Please try again."
+            );
+            process.exit(1);
+          }
           const errorText = await publishersResponse.text();
           out.warning("Failed to fetch publishers", [errorText]);
         } else {
@@ -520,15 +572,18 @@ export async function deployCommand(options: DeployOptions) {
     const urlPath = deploymentId || "personal";
 
     try {
-      const response = await fetch(`${options.apiUrl}/v1/twist/${urlPath}`, {
-        method: "POST",
-        headers: {
-          "Content-Type": "application/json",
-          Accept: "text/event-stream",
-          Authorization: `Bearer ${deployToken}`,
-        },
-        body: JSON.stringify(requestBody),
-      });
+      const response = await fetchWithRetry(
+        `${options.apiUrl}/v1/twist/${urlPath}`,
+        {
+          method: "POST",
+          headers: {
+            "Content-Type": "application/json",
+            Accept: "text/event-stream",
+            Authorization: `Bearer ${deployToken}`,
+          },
+          body: JSON.stringify(requestBody),
+        }
+      );
 
       if (!response.ok) {
         if (response.status === 401) {
@@ -538,6 +593,13 @@ export async function deployCommand(options: DeployOptions) {
           );
           process.exit(1);
         }
+        if (response.status >= 500) {
+          out.error(
+            "Server error",
+            "The Plot API is temporarily unavailable. Please try again."
+          );
+          process.exit(1);
+        }
         const errorText = await response.text();
         out.error("Upload failed", errorText);
         process.exit(1);