Fix TTL updating

Remove type comparison as we're alredy filtering when we query the zone for the
domain.
Call record.save only once as it publishes the DNS zone.

Per DNS RFC, all records under the same node must have the same TTL

Author: Yarden Bar

lib/puppet/provider/dns_record/dynect.rb

@@ -101,22 +101,21 @@ def flush
         r.destroy
         publish_zone = true
       end
+      needs_update = false
       existing.each do |r|
-        if r.type != resource[:type]
-          r.type = resource[:type]
-          needs_update = true
-        end
-        if (! r.ttl.nil?) && r.ttl != resource[:ttl]
+        if r.ttl != resource[:ttl]
           r.ttl = resource[:ttl]
           needs_update = true
         end
-        if needs_update
-          Puppet.debug("Updating #{r.inspect}")
-          r.save
-          publish_zone = true
-        end
         content_dup -= [r.rdata['address']]
       end
+      if needs_update
+        Puppet.debug("Updating #{resource[:name]}")
+        # Calling 'save' applys changes on all DNS node records and 'publish's
+        # the zone. so it's enough to call save on the 1st record
+        existing[0].save(true) # replace
+        publish_zone = true
+      end
       Puppet.debug("content_dup-2: #{content_dup}")
       # The remaining records in content_dup are 'new' and should be created
       if !content_dup.empty?